DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver
@ 2015-03-12 21:38 Jia Yu
  2015-03-23 11:31 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Jia Yu @ 2015-03-12 21:38 UTC (permalink / raw)
  To: dev

eth_driver already contains rte_pci_driver data structure.
Allocating rte_pci_driver without referencing it after bond
creation causes memory leakage.
---
 lib/librte_pmd_bond/rte_eth_bond_api.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/lib/librte_pmd_bond/rte_eth_bond_api.c b/lib/librte_pmd_bond/rte_eth_bond_api.c
index 903b7c3..13f3941 100644
--- a/lib/librte_pmd_bond/rte_eth_bond_api.c
+++ b/lib/librte_pmd_bond/rte_eth_bond_api.c
@@ -230,11 +230,8 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id)
 		goto err;
 	}
 
-	pci_drv = rte_zmalloc_socket(name, sizeof(*pci_drv), 0, socket_id);
-	if (pci_drv == NULL) {
-		RTE_BOND_LOG(ERR, "Unable to malloc pci_drv on socket");
-		goto err;
-	}
+	pci_drv = &eth_drv->pci_drv;
+
 	pci_id_table = rte_zmalloc_socket(name, sizeof(*pci_id_table), 0, socket_id);
 	if (pci_id_table == NULL) {
 		RTE_BOND_LOG(ERR, "Unable to malloc pci_id_table on socket");
@@ -266,9 +263,7 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id)
 	pci_dev->numa_node = socket_id;
 	pci_drv->name = driver_name;
 
-	eth_drv->pci_drv = (struct rte_pci_driver)(*pci_drv);
 	eth_dev->driver = eth_drv;
-
 	eth_dev->data->dev_private = internals;
 	eth_dev->data->nb_rx_queues = (uint16_t)1;
 	eth_dev->data->nb_tx_queues = (uint16_t)1;
@@ -325,8 +320,6 @@ rte_eth_bond_create(const char *name, uint8_t mode, uint8_t socket_id)
 err:
 	if (pci_dev)
 		rte_free(pci_dev);
-	if (pci_drv)
-		rte_free(pci_drv);
 	if (pci_id_table)
 		rte_free(pci_id_table);
 	if (eth_drv)
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver
  2015-03-12 21:38 [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver Jia Yu
@ 2015-03-23 11:31 ` Thomas Monjalon
  2015-03-26 11:57   ` Declan Doherty
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2015-03-23 11:31 UTC (permalink / raw)
  To: Jia Yu, Declan Doherty; +Cc: dev

Declan,
Any comment?

2015-03-12 14:38, Jia Yu:
> eth_driver already contains rte_pci_driver data structure.
> Allocating rte_pci_driver without referencing it after bond
> creation causes memory leakage.

Jia, Signed-off is missing.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver
  2015-03-23 11:31 ` Thomas Monjalon
@ 2015-03-26 11:57   ` Declan Doherty
  0 siblings, 0 replies; 3+ messages in thread
From: Declan Doherty @ 2015-03-26 11:57 UTC (permalink / raw)
  To: Thomas Monjalon, Jia Yu; +Cc: dev

On 23/03/15 11:31, Thomas Monjalon wrote:
> Declan,
> Any comment?
>
> 2015-03-12 14:38, Jia Yu:
>> eth_driver already contains rte_pci_driver data structure.
>> Allocating rte_pci_driver without referencing it after bond
>> creation causes memory leakage.
>
> Jia, Signed-off is missing.
>

Hey Thomas, I've been away for a few days but this looks fine, I'll ack 
the v2.

Declan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-26 11:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-12 21:38 [dpdk-dev] [PATCH] librte_pmd_bond: remove memory alloc for rte_pci_driver Jia Yu
2015-03-23 11:31 ` Thomas Monjalon
2015-03-26 11:57   ` Declan Doherty

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git