From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D4F931B3D2 for ; Thu, 4 Apr 2019 23:43:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 65DCE22011; Thu, 4 Apr 2019 17:43:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 17:43:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ftuyiBJIMVUbDiKXty49qkuj4W6FB8MGDqCfZlzY5cE=; b=X9bl8FbQotXm Xbq1ZJYQDdBCu6BicIE9rLqYe3sF7P7PvbcwBbeOLXrRg2T/CFrqjUgQn3MldfNh I5O848exkPiq+uBJq5+eL6CzdksvtgBy6gA7erUC93zsg6jOz5d8HVwl7kMKq5jM /nXk4FLoaazp1AVq1Gc/Hr7qeZCGyFI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ftuyiBJIMVUbDiKXty49qkuj4W6FB8MGDqCfZlzY5 cE=; b=vxwUHUvVdDUfWjbV9bpzUhVT+ZZzQ8MjZNjO8Za7oNX5CWhN4xAzEcooA orFMby80mYQe2EP4poaKRNyjcO/WrdlB26dABWtgbCBKW2Hl1kD6xvL3LeknJT83 lEU9srdiEeWantOfpjBVBePE1kqZ0qwJ3eOKOLIsWc850/LmMfy6WBAmhABrYUuA 4uy16c7C7j9kXy/dfXKh95RlVxMAqXi7goxZvP+5x/oyN4Qn/Qef3KojI8hQGDrR szSNcCM7WgbtdnfTrmkYO6Im6NB/NQLYdXw+QX3T3LqgH52XUUtyiOYXbYpFEyE/ an5Olu467jPNHC4lDUocCJ5dubNTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdduieefucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13CAF10316; Thu, 4 Apr 2019 17:43:25 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shreyansh Jain Date: Thu, 04 Apr 2019 23:43:24 +0200 Message-ID: <5514293.kQscWdxMbc@xps> In-Reply-To: References: <20190403142357.17700-1-shreyansh.jain@nxp.com> <20190404072335.24555-2-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 21:43:28 -0000 04/04/2019 23:29, Ferruh Yigit: > On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > > Removes some unused firmware code which was added in last bump > > of the firmware version. No current features uses these APIs. > > > > Signed-off-by: Shreyansh Jain > > <...> > > > diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h > > index 9af9097e5..cf3d15267 100644 > > --- a/drivers/bus/fslmc/mc/fsl_dpci.h > > +++ b/drivers/bus/fslmc/mc/fsl_dpci.h > > @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, > > uint16_t token, > > struct dpci_attr *attr); > > > > -/** > > - * struct dpci_peer_attr - Structure representing the peer DPCI attributes > > - * @peer_id: DPCI peer id; if no peer is connected returns (-1) > > - * @num_of_priorities: The pper's number of receive priorities; determines the > > - * number of transmit priorities for the local DPCI object > > - */ > > -struct dpci_peer_attr { > > - int peer_id; > > - uint8_t num_of_priorities; > > -}; > > - > > -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - struct dpci_peer_attr *attr); > > - > > -int dpci_get_link_state(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - int *up); > > These needs to be removed from .map file too. Removed from master. Thanks for the catch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D438AA0679 for ; Thu, 4 Apr 2019 23:43:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA03A1B3D7; Thu, 4 Apr 2019 23:43:28 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D4F931B3D2 for ; Thu, 4 Apr 2019 23:43:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 65DCE22011; Thu, 4 Apr 2019 17:43:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 17:43:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ftuyiBJIMVUbDiKXty49qkuj4W6FB8MGDqCfZlzY5cE=; b=X9bl8FbQotXm Xbq1ZJYQDdBCu6BicIE9rLqYe3sF7P7PvbcwBbeOLXrRg2T/CFrqjUgQn3MldfNh I5O848exkPiq+uBJq5+eL6CzdksvtgBy6gA7erUC93zsg6jOz5d8HVwl7kMKq5jM /nXk4FLoaazp1AVq1Gc/Hr7qeZCGyFI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ftuyiBJIMVUbDiKXty49qkuj4W6FB8MGDqCfZlzY5 cE=; b=vxwUHUvVdDUfWjbV9bpzUhVT+ZZzQ8MjZNjO8Za7oNX5CWhN4xAzEcooA orFMby80mYQe2EP4poaKRNyjcO/WrdlB26dABWtgbCBKW2Hl1kD6xvL3LeknJT83 lEU9srdiEeWantOfpjBVBePE1kqZ0qwJ3eOKOLIsWc850/LmMfy6WBAmhABrYUuA 4uy16c7C7j9kXy/dfXKh95RlVxMAqXi7goxZvP+5x/oyN4Qn/Qef3KojI8hQGDrR szSNcCM7WgbtdnfTrmkYO6Im6NB/NQLYdXw+QX3T3LqgH52XUUtyiOYXbYpFEyE/ an5Olu467jPNHC4lDUocCJ5dubNTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdduieefucdltddurdeguddtrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfhgggfgtsehtufertddttddv necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghm pehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhush htvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13CAF10316; Thu, 4 Apr 2019 17:43:25 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shreyansh Jain Date: Thu, 04 Apr 2019 23:43:24 +0200 Message-ID: <5514293.kQscWdxMbc@xps> In-Reply-To: References: <20190403142357.17700-1-shreyansh.jain@nxp.com> <20190404072335.24555-2-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404214324.0NLJSl_wgBnXGC3lFZxJUK2OMn5-uv7-T24GCeO6LqA@z> 04/04/2019 23:29, Ferruh Yigit: > On 4/4/2019 8:23 AM, Shreyansh Jain wrote: > > Removes some unused firmware code which was added in last bump > > of the firmware version. No current features uses these APIs. > > > > Signed-off-by: Shreyansh Jain > > <...> > > > diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h > > index 9af9097e5..cf3d15267 100644 > > --- a/drivers/bus/fslmc/mc/fsl_dpci.h > > +++ b/drivers/bus/fslmc/mc/fsl_dpci.h > > @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, > > uint16_t token, > > struct dpci_attr *attr); > > > > -/** > > - * struct dpci_peer_attr - Structure representing the peer DPCI attributes > > - * @peer_id: DPCI peer id; if no peer is connected returns (-1) > > - * @num_of_priorities: The pper's number of receive priorities; determines the > > - * number of transmit priorities for the local DPCI object > > - */ > > -struct dpci_peer_attr { > > - int peer_id; > > - uint8_t num_of_priorities; > > -}; > > - > > -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - struct dpci_peer_attr *attr); > > - > > -int dpci_get_link_state(struct fsl_mc_io *mc_io, > > - uint32_t cmd_flags, > > - uint16_t token, > > - int *up); > > These needs to be removed from .map file too. Removed from master. Thanks for the catch.