From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A35991B5E2 for ; Wed, 4 Oct 2017 00:07:55 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2017 15:07:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,475,1500966000"; d="scan'208";a="906389912" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.245]) ([10.241.224.245]) by FMSMGA003.fm.intel.com with ESMTP; 03 Oct 2017 15:07:53 -0700 To: Matan Azrad , Pascal Mazon Cc: dev@dpdk.org References: <1507042556-9839-1-git-send-email-matan@mellanox.com> From: Ferruh Yigit Message-ID: <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> Date: Tue, 3 Oct 2017 23:07:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507042556-9839-1-git-send-email-matan@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2017 22:07:56 -0000 On 10/3/2017 3:55 PM, Matan Azrad wrote: > Missed 4 spaces were added after break if line. > > Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") What do you think fixing this when that code has been touched next time? > > Signed-off-by: Matan Azrad > --- > drivers/net/tap/tap_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c > index eefa868..aa33960 100644 > --- a/drivers/net/tap/tap_flow.c > +++ b/drivers/net/tap/tap_flow.c > @@ -1093,7 +1093,7 @@ struct tap_flow_items { > goto exit_action_not_supported; > action = 1; > if (!queue || > - (queue->index > pmd->dev->data->nb_rx_queues - 1)) > + (queue->index > pmd->dev->data->nb_rx_queues - 1)) > goto exit_action_not_supported; > if (flow) > err = add_action_skbedit(flow, queue->index); >