From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id C49CA3B5 for ; Fri, 5 May 2017 15:46:35 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1C09920CB0; Fri, 5 May 2017 09:46:35 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 05 May 2017 09:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=T4L66BXaWRey/nU 4rdXAztVWk3ihZf2G2Vi2oexIY4w=; b=c7e/FfwxljXtZDt9gT3FWYbFGTWPyQr Msndf4Ee4yOn05MTZCrQ+3FFfqy121AMq5mEicXqz8+dOLTg7iF29CDoNk0/i6FE gpD+OYFhuty8USYjTVuxn8cGb1aeoOXbzFr8AV9bxOLgiRK9JbLPS3knCeKfQDsl n1AKJPu3wTsY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=T4L66BXaWRey/nU4rdXAztVWk3ihZf2G2Vi2oexIY4w=; b=MbxONXTL 0Jv1ghyOnm/nYzxDGwukJWsNd7qcX3t4lT+6fE64D/sgiwR5yQOX9ha7Dlcnc0iu rs8MX1RV4R57qUDEbgSx4KoQ4ad/hZHtayoDuCpMUg+jWUyPgoLPBb665EDtfigq daAO3E8KT02VmXan0kuYrEFgdN/dGMdwaKSjPxGyKHoNASxBh+SocAB8stz8XGV2 RcZkygBOAbknqoPBIuYu9HuhhBYOqBYCf/EjkQ22mAf+F/MgrGnbCr52WHkoCrs6 +F/7qJbb++I4LSeNJo59/tFD2id1oLcF9vsh1cAcyxDWkWmXr0KUm9UQ2CtJRAro Ec39iyq6aJYGfQ== X-ME-Sender: X-Sasl-enc: joKu6cpYtGPNc89gAgoBg+xw/thM6UOvodDa72G96pmv 1493991994 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C04AC240A5; Fri, 5 May 2017 09:46:34 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, nicolas.dichtel@6wind.com Date: Fri, 05 May 2017 15:46:33 +0200 Message-ID: <5520116.VeCXaXWujL@xps> In-Reply-To: <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com> References: <20170503160016.31375-1-ferruh.yigit@intel.com> <48ab36d4-db15-4a46-dc8e-03954ed55452@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 May 2017 13:46:36 -0000 03/05/2017 19:06, Nicolas Dichtel: > Le 03/05/2017 =C3=A0 18:43, Ferruh Yigit a =C3=A9crit : > > On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: > >> Le 03/05/2017 =C3=A0 18:00, Ferruh Yigit a =C3=A9crit : > >>> build error: > >>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: > >>> error: implicit declaration of function =E2=80=98pci_enable_msix=E2= =80=99 > >>> [-Werror=3Dimplicit-function-declaration] > >>> err =3D pci_enable_msix(pdev, > >>> ^~~~~~~~~~~~~~~ > >>> > >>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config opt= ion > >>> enabled. > >>> > >>> Following Linux commit removes the pci_enable_msix() > >>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix") > >>> > >>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux > >>> igb driver uses this function. > >> When looking at the kernel patches, it seems that the way to go is to = use > >> pci_alloc_irq_vectors(), but it needs a bit more work. > >=20 > > I remember this from your igb_uio fix, but latest igb kernel driver uses > > pci_enable_msix_range(), I found it easy and safe to replicate it. > Ok. >=20 > >=20 > > We can update it when kernel igb driver updates the code, unless you > > have a strong opinion to switch pci_alloc_irq_vectors() in advance? > No, I don't mind. >=20 > Acked-by: Nicolas Dichtel Applied, thanks