From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id D80D547D2
 for <dev@dpdk.org>; Tue, 22 Nov 2016 10:38:41 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id t79so14944116wmt.0
 for <dev@dpdk.org>; Tue, 22 Nov 2016 01:38:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=f2gnPGliMJICp8ftVhzPxzfZaFgw4d+ClMAJFbIShHo=;
 b=iQBdsGRQXZLzpKlYG7KGUskCZw7plrJrYruQPklYtA7znFtSvE+L3v6GzN4o048ZxB
 NV2BCLSn2o5diCiZJpPH1hO09oSC11Jitr7mV+ekMKacjy2iJGIL/rEVzTQJzdl3lcmi
 HbA2xAsI6tpuL98ctQdIrYWstNMED/eSeuwL5+0MYHlTXcGGWwF04lrLfHqOXYO+59cC
 y8ZJc73rudmVlOeW9S0Dled1l40OIEusEBsrx29/yyCrBN0FTH634HaovyUcFBdpYLe8
 Aw8Of3wYJq9sZelu9Q0ILJBMz/r5i1q6rS1+bWW6mpm0OF5VsQ3r6/TKCr7rtxHHBAzb
 RD9g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=f2gnPGliMJICp8ftVhzPxzfZaFgw4d+ClMAJFbIShHo=;
 b=V3qg5mRUTxqaS/PlxP8tDQoeN+abIsxEtCvQweyhMo0ZuY0fn9i054UtFoXzJp+Put
 G2Odkt9Ps6DH/4Up7DsUe+52QE2/jIwMib5JGNWl1qMwtnrnZNgg6R29V10rXOLcP06y
 8hqVSpJWEsnE/7aisVL75dSvwy7nlKkH/dr/MGBWS0J0NpuABEarIT5CSNRc2hcMJewJ
 VrQta2yknNX0op+cILex3GixH0NSuxiyS9qXqPHNUDOgpQw+g8sjwRrZikHuoB3UVHf0
 eMJYF5pFyLZQuMytOIoh0xYQBR/vUW9+QujSqPchjZMUSKnJusLkRhnf6KfOBlgliG87
 RSyw==
X-Gm-Message-State: AKaTC03lRgJvRMsKSSLkwyLTYv1Ur7FFWlZuE26PoTi+rPcBVdOo53SPAR6gEHa3jCpH4vcE
X-Received: by 10.28.180.214 with SMTP id d205mr1467835wmf.131.1479807521517; 
 Tue, 22 Nov 2016 01:38:41 -0800 (PST)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id ef10sm10300981wjd.22.2016.11.22.01.38.40
 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
 Tue, 22 Nov 2016 01:38:40 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Date: Tue, 22 Nov 2016 10:38:39 +0100
Message-ID: <5520615.NhohP7H5Lc@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <bebe9fe0-3ef7-8800-1a5b-66e8d3b2f21a@intel.com>
References: <1479772058-7112-1-git-send-email-thomas.monjalon@6wind.com>
 <bebe9fe0-3ef7-8800-1a5b-66e8d3b2f21a@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] mk: remove make target for examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2016 09:38:42 -0000

2016-11-22 00:34, Ferruh Yigit:
> On 11/21/2016 11:47 PM, Thomas Monjalon wrote:
> > The command
> >   make examples
> > works only if target directories have the exact name of configs.
> > 
> > It is more flexible to use
> >   make -C examples RTE_SDK=$(pwd) RTE_TARGET=build
> > 
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> 
> Instead of removing examples & examples_clean targets, what do you think
> keeping them as wrapper to suggested usage, for backward compatibility.
> 
> Something like:
> "
> BUILDING_RTE_SDK :=
> export BUILDING_RTE_SDK
> 
> # Build directory is given with O=
> O ?= $(RTE_SDK)/examples
> 
> # Target for which examples should be built.
> T ?= build
> 
> .PHONY: examples
> examples:
>         @echo ================== Build examples for $(T)
>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T);
> 
> .PHONY: examples_clean
> examples_clean:
>         @echo ================== Clean examples for $(T)
>         $(MAKE) -C examples O=$(abspath $(O)) RTE_TARGET=$(T) clean;
> "

What is the benefit of this makefile? Just remove -C ?
It is not compatible with the old behaviour, so I'm afraid it would be
confusing for no real benefit.