From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1AA11FE5
 for <dev@dpdk.org>; Tue,  7 Apr 2015 16:38:00 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 07 Apr 2015 07:38:00 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,538,1422950400"; d="scan'208";a="709935050"
Received: from unknown (HELO [10.217.248.56]) ([10.217.248.56])
 by orsmga002.jf.intel.com with ESMTP; 07 Apr 2015 07:37:59 -0700
Message-ID: <5523EBC6.7070203@intel.com>
Date: Tue, 07 Apr 2015 16:37:58 +0200
From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: dev@dpdk.org
References: <1428339685-27686-1-git-send-email-ehkinzie@gmail.com>
 <1428339685-27686-5-git-send-email-ehkinzie@gmail.com>
 <5523E720.2050207@intel.com>
In-Reply-To: <5523E720.2050207@intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Apr 2015 14:38:01 -0000

On 2015-04-07 16:18, Pawel Wodkowski wrote:

>
> Also, maybe a renaming "external_sm" to "state_machine_cb", set it to
> against default one and using it without "if()" will simplify code. It
> is no crucial but will eliminate couple of if's. In
> rte_eth_bond_8023ad_ext_slowtx() you can compare it against default one.

Oh, I read what I wrote :)
Please ignore that.

-- 
Pawel