From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CF4D05921 for ; Thu, 9 Apr 2015 11:42:09 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 09 Apr 2015 02:42:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,549,1422950400"; d="scan'208";a="692731968" Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga001.fm.intel.com with ESMTP; 09 Apr 2015 02:42:08 -0700 Message-ID: <5526496F.6080201@intel.com> Date: Thu, 09 Apr 2015 10:42:07 +0100 From: "Gonzalez Monroy, Sergio" User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Avi Kivity References: <1428505645-5578-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1428505645-5578-2-git-send-email-sergio.gonzalez.monroy@intel.com> <20150408112619.14596b65@urahara> <55263955.1070707@intel.com> <55264127.2020604@cloudius-systems.com> In-Reply-To: <55264127.2020604@cloudius-systems.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/5] mk: remove combined library and related options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2015 09:42:10 -0000 On 09/04/2015 10:06, Avi Kivity wrote: > > > On 04/09/2015 11:33 AM, Gonzalez Monroy, Sergio wrote: >> On 08/04/2015 19:26, Stephen Hemminger wrote: >>> On Wed, 8 Apr 2015 16:07:21 +0100 >>> Sergio Gonzalez Monroy wrote: >>> >>>> Currently, the target/rules to build combined libraries is different >>>> than the one to build individual libraries. >>>> >>>> By removing the combined library option as a build configuration >>>> option >>>> we simplify the build pocess by having a single point for >>>> linking/archiving >>>> libraries in DPDK. >>>> >>>> This patch removes CONFIG_RTE_BUILD_COMBINE_LIB build config option >>>> and >>>> removes the makefiles associated with building a combined library. >>>> >>>> The CONFIG_RTE_LIBNAME config option is kept as it will be use to >>>> always generate a linker script that acts as a single combined >>>> library. >>>> >>>> Signed-off-by: Sergio Gonzalez Monroy >>>> >>> No. We use combined library and it greatly simplfies the application >>> linking process. >>> >> After all the opposition this patch had in v2, I did explain the >> current issues >> (see http://dpdk.org/ml/archives/dev/2015-March/015366.html ) and >> this was the agreed solution. >> >> As I mention in the cover letter (also see patch 2/5), building DPDK >> (after applying this patch series) will always generate a very simple >> linker script that behaves as a combined library. >> I encourage you to apply this patch series and try to build your app >> (which links against combined lib). >> Your app should build without problem unless I messed up somewhere >> and it needs fixing. > > Is it possible to generate a pkgconfig file (dpdk.pc) that contains > all of the setting needed to compile and link with dpdk? That will > greatly simplify usage. > > A linker script is just too esoteric. > > That sounds very interesting. I would be in favor of dropping the linker script for this solution if everybody is happy with it. Sergio