From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
To: Eric Kinzie <ehkinzie@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/5] bond mode 4: do not ignore multicast
Date: Fri, 10 Apr 2015 09:56:05 +0200 [thread overview]
Message-ID: <55278215.2000702@intel.com> (raw)
In-Reply-To: <1428339685-27686-4-git-send-email-ehkinzie@gmail.com>
On 2015-04-06 19:01, Eric Kinzie wrote:
> if (unlikely(hdr->ether_type == ether_type_slow_be ||
> !collecting || (!promisc &&
> - !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) {
> + (!is_multicast_ether_addr(&hdr->d_addr) &&
> + !is_same_ether_addr(&bond_mac, &hdr->d_addr))))) {
>
You can drop extra parenthesis here, but beside that I think it is OK.
Should be marked as bugfix.
Acked-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
next prev parent reply other threads:[~2015-04-10 7:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 17:01 [dpdk-dev] [PATCH 0/5] bonding corrections and additions Eric Kinzie
2015-04-06 17:01 ` [dpdk-dev] [PATCH 1/5] bond: use existing enslaved device queues Eric Kinzie
2015-04-10 7:40 ` Pawel Wodkowski
2015-04-14 14:29 ` Eric Kinzie
2015-04-14 14:34 ` Wodkowski, PawelX
2015-04-06 17:01 ` [dpdk-dev] [PATCH 2/5] bond mode 4: copy entire config structure Eric Kinzie
2015-04-10 7:47 ` Pawel Wodkowski
2015-04-10 7:55 ` Thomas Monjalon
2015-04-06 17:01 ` [dpdk-dev] [PATCH 3/5] bond mode 4: do not ignore multicast Eric Kinzie
2015-04-10 7:56 ` Pawel Wodkowski [this message]
2015-04-06 17:01 ` [dpdk-dev] [PATCH 4/5] bond mode 4: allow external state machine Eric Kinzie
2015-04-07 14:18 ` Pawel Wodkowski
2015-04-07 14:37 ` Pawel Wodkowski
2015-04-07 17:31 ` Eric Kinzie
2015-04-10 8:29 ` Pawel Wodkowski
2015-04-06 17:01 ` [dpdk-dev] [PATCH 5/5] bond mode 4: tests for " Eric Kinzie
2015-04-10 8:41 ` Pawel Wodkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55278215.2000702@intel.com \
--to=pawelx.wodkowski@intel.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).