From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2EA587EB0 for ; Fri, 10 Apr 2015 09:56:07 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 10 Apr 2015 00:56:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,555,1422950400"; d="scan'208";a="678158512" Received: from unknown (HELO [10.217.248.56]) ([10.217.248.56]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2015 00:56:06 -0700 Message-ID: <55278215.2000702@intel.com> Date: Fri, 10 Apr 2015 09:56:05 +0200 From: Pawel Wodkowski User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Eric Kinzie , "dev@dpdk.org" References: <1428339685-27686-1-git-send-email-ehkinzie@gmail.com> <1428339685-27686-4-git-send-email-ehkinzie@gmail.com> In-Reply-To: <1428339685-27686-4-git-send-email-ehkinzie@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/5] bond mode 4: do not ignore multicast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2015 07:56:08 -0000 On 2015-04-06 19:01, Eric Kinzie wrote: > if (unlikely(hdr->ether_type == ether_type_slow_be || > !collecting || (!promisc && > - !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) { > + (!is_multicast_ether_addr(&hdr->d_addr) && > + !is_same_ether_addr(&bond_mac, &hdr->d_addr))))) { > You can drop extra parenthesis here, but beside that I think it is OK. Should be marked as bugfix. Acked-by: Pawel Wodkowski