From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 7D2B85A84 for ; Tue, 14 Apr 2015 14:48:36 +0200 (CEST) Received: by wiax7 with SMTP id x7so87738190wia.0 for ; Tue, 14 Apr 2015 05:48:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=cxFeFitU6+chLGqlh5rccvm8H14I586HsCcTwgBESJM=; b=fk7t5rKYrSOKA2dpfooCeQbF1AeQf5OHu6r14nbfEUo+RDXPDouxX4mfv7uBXfIC23 FYmKHgafsPFi6TIrJZDD+eEtdT0Q/VBBHglGErB0g4a1GZo1ojcl0EnSBPRIJ0E4rIi1 GifkyUJhT+468geBG/a3on6k8wufSzNQ5bMn6ND9X091wIoAjR19wDvCwXZ10WgPM1ca SSoPsARaefDqVH0Z28W7UXM+oLwUL80PChFr/ExGXVMSEohQ6K4pRsOYu7DZJFcuECNo wIvx1kO2ai7nNGo+MXPespbJjSV5ZkflG8sZB9OQ8F1KuoHoxavBHD214oeJNITggd33 rmeQ== X-Gm-Message-State: ALoCoQn93tG5fqPL5NjOocOJ4s7tNOqkSzt7QHElrSVGGKWk5D24nD8dssxGrMB6xnAa0uZBsBsa X-Received: by 10.180.230.226 with SMTP id tb2mr31692716wic.64.1429015716298; Tue, 14 Apr 2015 05:48:36 -0700 (PDT) Received: from [10.0.0.166] ([212.143.139.214]) by mx.google.com with ESMTPSA id ax10sm1449434wjc.26.2015.04.14.05.48.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 05:48:35 -0700 (PDT) Message-ID: <552D0CA2.9080905@cloudius-systems.com> Date: Tue, 14 Apr 2015 15:48:34 +0300 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Monjalon , Konstantin Ananyev , Helin Zhang References: <1429003900-20074-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1429003900-20074-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 4.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 12:48:36 -0000 On 04/14/15 12:31, Thomas Monjalon wrote: > With GCC 4.4.7 from CentOS 6.5, the following errors arise: > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_dev_rx_queue_setup’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for ‘dev_info.driver_name’) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_set_rsc’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for ‘dev_info.driver_name’) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_recv_pkts_lro_single_alloc’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: ‘next_rsc_entry’ may be used uninitialized in this function > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: ‘next_rxe’ may be used uninitialized in this function > > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > > Signed-off-by: Thomas Monjalon > --- > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index f1da9ec..a2b8631 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > bool eop; > struct ixgbe_rx_entry *rxe; > struct ixgbe_rsc_entry *rsc_entry; > - struct ixgbe_rsc_entry *next_rsc_entry; > - struct ixgbe_rx_entry *next_rxe; > + struct ixgbe_rsc_entry *next_rsc_entry = NULL; > + struct ixgbe_rx_entry *next_rxe = NULL; > struct rte_mbuf *first_seg; > struct rte_mbuf *rxm; > struct rte_mbuf *nmb; > @@ -2506,7 +2506,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, > struct ixgbe_rx_queue *rxq; > struct ixgbe_hw *hw; > uint16_t len; > - struct rte_eth_dev_info dev_info = { 0 }; > + struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 }; > struct rte_eth_rxmode *dev_rx_mode = &dev->data->dev_conf.rxmode; > bool rsc_requested = false; > > @@ -4069,7 +4069,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) > { > struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode; > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > - struct rte_eth_dev_info dev_info = { 0 }; > + struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 }; Hmmm... Unless I miss something this and one above would zero only a single field - "max_rx_queues"; and would leave the rest uninitialized. The original code intend to zero the whole struct. The alternative to the original lines could be usage of memset(). > bool rsc_capable = false; > uint16_t i; > uint32_t rdrxctl;