From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 10C002A5B for ; Tue, 14 Apr 2015 15:42:00 +0200 (CEST) Received: by wgyo15 with SMTP id o15so12428926wgy.2 for ; Tue, 14 Apr 2015 06:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=c2m+TsYMZtEbHgo81FHerx58cJxc8xnLJrXFWM+XAqc=; b=cUFyzTPJ38eKeXRzf3l6JR4jtUoY+P9RVJDruCpGHm04TcOSkP/UEM1FGdIMvp6Mpp RtlqNElCbZYZyIncE0WepVknC7F0hUHh3EDpTt1L7pohlv0nyatrEEThXhSln/C5OKpk xyDO9IU/11tp3wWdHCtoVg5YYb1iFm4+/CBmvIdM0AkcEZJ6oMZGMcREiAQLevMJXP2u WTD6yi+SiSbaBTeOsrcDMTcOFsx7RPIyX+NuuWOiXdx2FFF63g/ZSGlxloUfQ+WF9Fdp pTMKQ/OdPaxmXOqTF4RSfc+03vdl3lEzfBztnxr4lBseedLqK48vpmqxn4Qg30KAPTkn EQrw== X-Gm-Message-State: ALoCoQnri9eqWLs3ozuJay+FRkj+tB8uE+fXfr8K8kgk0GmF+7JBswvcv71Iv7g5oBSOXE6gFHxO X-Received: by 10.180.78.65 with SMTP id z1mr32626563wiw.14.1429018919853; Tue, 14 Apr 2015 06:41:59 -0700 (PDT) Received: from [10.0.0.166] ([212.143.139.214]) by mx.google.com with ESMTPSA id b5sm17315203wiw.8.2015.04.14.06.41.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 06:41:59 -0700 (PDT) Message-ID: <552D1925.4090609@cloudius-systems.com> Date: Tue, 14 Apr 2015 16:41:57 +0300 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Ananyev, Konstantin" , Thomas Monjalon , "Zhang, Helin" References: <1429003900-20074-1-git-send-email-thomas.monjalon@6wind.com> <552D0D65.6040500@cloudius-systems.com> <2601191342CEEE43887BDE71AB97725821415914@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725821415914@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix build with gcc 4.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 13:42:00 -0000 On 04/14/15 16:23, Ananyev, Konstantin wrote: > >> -----Original Message----- >> From: Vlad Zolotarov [mailto:vladz@cloudius-systems.com] >> Sent: Tuesday, April 14, 2015 1:52 PM >> To: Thomas Monjalon; Ananyev, Konstantin; Zhang, Helin >> Cc: dev@dpdk.org >> Subject: Re: [PATCH] ixgbe: fix build with gcc 4.4 >> >> >> >> On 04/14/15 12:31, Thomas Monjalon wrote: >>> With GCC 4.4.7 from CentOS 6.5, the following errors arise: >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_dev_rx_queue_setup’: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for ‘dev_info.driver_name’) >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_set_rsc’: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for ‘dev_info.driver_name’) >>> >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_recv_pkts_lro_single_alloc’: >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: ‘next_rsc_entry’ may be used uninitialized in this function >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: ‘next_rxe’ may be used uninitialized in this function >> :D Looks like a gcc bug ;) Both are set and only after that (!!!) used >> under "!eop" condition. > Possibly, but we still need to make it build cleanly. It's clearly - I was just trying to be polite here... ;) Please, add the comment explaining this initialization so that nobody removes these workarounds by mistake... > Konstantin > >>> Fixes: 8eecb3295aed ("ixgbe: add LRO support") >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>> index f1da9ec..a2b8631 100644 >>> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c >>> @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, >>> bool eop; >>> struct ixgbe_rx_entry *rxe; >>> struct ixgbe_rsc_entry *rsc_entry; >>> - struct ixgbe_rsc_entry *next_rsc_entry; >>> - struct ixgbe_rx_entry *next_rxe; >>> + struct ixgbe_rsc_entry *next_rsc_entry = NULL; >>> + struct ixgbe_rx_entry *next_rxe = NULL; >>> struct rte_mbuf *first_seg; >>> struct rte_mbuf *rxm; >>> struct rte_mbuf *nmb; >>> @@ -2506,7 +2506,7 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, >>> struct ixgbe_rx_queue *rxq; >>> struct ixgbe_hw *hw; >>> uint16_t len; >>> - struct rte_eth_dev_info dev_info = { 0 }; >>> + struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 }; >>> struct rte_eth_rxmode *dev_rx_mode = &dev->data->dev_conf.rxmode; >>> bool rsc_requested = false; >>> >>> @@ -4069,7 +4069,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) >>> { >>> struct rte_eth_rxmode *rx_conf = &dev->data->dev_conf.rxmode; >>> struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); >>> - struct rte_eth_dev_info dev_info = { 0 }; >>> + struct rte_eth_dev_info dev_info = { .max_rx_queues = 0 }; >>> bool rsc_capable = false; >>> uint16_t i; >>> uint32_t rdrxctl;