From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] mk: update app linking flags against shared libs
Date: Wed, 15 Apr 2015 15:17:50 +0100 [thread overview]
Message-ID: <552E730E.2060901@intel.com> (raw)
In-Reply-To: <1429090230-25137-4-git-send-email-sergio.gonzalez.monroy@intel.com>
On 15/04/2015 10:30, Sergio Gonzalez Monroy wrote:
> Use flag --as-needed when linking against shared libs, exluding
> eal, malloc, mempool and ring as explained in:
> 7cee5f6b4a9b ("lib: set LDLIBS for each library")
Self-NACK. It is not correct to put the commit id here (it does not
exist after all :) ).
I'll send v2 with new commit message, but I'd wait until someone review
the rest of the patch first.
Sergio
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
> mk/rte.app.mk | 36 ++++++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 62a76ae..c557957 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -67,6 +67,26 @@ endif
>
> ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>
> +ifeq ($(CONFIG_RTE_LIBRTE_EAL),y)
> +LDLIBS += -lrte_eal
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y)
> +LDLIBS += -lrte_malloc
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_MEMPOOL),y)
> +LDLIBS += -lrte_mempool
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_RING),y)
> +LDLIBS += -lrte_ring
> +endif
> +
> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> +LDLIBS += --as-needed
> +endif
> +
> ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
> LDLIBS += -lrte_distributor
> endif
> @@ -171,22 +191,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y)
> LDLIBS += -lethdev
> endif
>
> -ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y)
> -LDLIBS += -lrte_malloc
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_MEMPOOL),y)
> -LDLIBS += -lrte_mempool
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_RING),y)
> -LDLIBS += -lrte_ring
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_EAL),y)
> -LDLIBS += -lrte_eal
> -endif
> -
> ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)
> LDLIBS += -lrte_cmdline
> endif
prev parent reply other threads:[~2015-04-15 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 9:30 [dpdk-dev] [PATCH 0/3] Add DT_NEEDED entries to " Sergio Gonzalez Monroy
2015-04-15 9:30 ` [dpdk-dev] [PATCH 1/3] lib: set LDLIBS for each library Sergio Gonzalez Monroy
2015-05-04 7:55 ` Olivier MATZ
2015-05-05 9:21 ` Gonzalez Monroy, Sergio
2015-05-05 11:22 ` Olivier MATZ
2015-04-15 9:30 ` [dpdk-dev] [PATCH 2/3] mk: use LDLIBS when linking shared libraries Sergio Gonzalez Monroy
2015-04-15 9:30 ` [dpdk-dev] [PATCH 3/3] mk: update app linking flags against shared libs Sergio Gonzalez Monroy
2015-04-15 14:17 ` Gonzalez Monroy, Sergio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E730E.2060901@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).