From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id AE9D59A8A
 for <dev@dpdk.org>; Wed, 15 Apr 2015 16:17:52 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 15 Apr 2015 07:17:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,582,1422950400"; d="scan'208";a="709487356"
Received: from smonroyx-mobl.ger.corp.intel.com (HELO [10.237.220.49])
 ([10.237.220.49])
 by fmsmga002.fm.intel.com with ESMTP; 15 Apr 2015 07:17:52 -0700
Message-ID: <552E730E.2060901@intel.com>
Date: Wed, 15 Apr 2015 15:17:50 +0100
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: dev@dpdk.org
References: <1429090230-25137-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1429090230-25137-4-git-send-email-sergio.gonzalez.monroy@intel.com>
In-Reply-To: <1429090230-25137-4-git-send-email-sergio.gonzalez.monroy@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 3/3] mk: update app linking flags against
 shared libs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Apr 2015 14:17:53 -0000

On 15/04/2015 10:30, Sergio Gonzalez Monroy wrote:
> Use flag --as-needed when linking against shared libs, exluding
> eal, malloc, mempool and ring as explained in:
> 7cee5f6b4a9b ("lib: set LDLIBS for each library")
Self-NACK. It is not correct to put the commit id here (it does not 
exist after all :) ).

I'll send v2 with new commit message, but I'd wait until someone review 
the rest of the patch first.

Sergio
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> ---
>   mk/rte.app.mk | 36 ++++++++++++++++++++----------------
>   1 file changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 62a76ae..c557957 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -67,6 +67,26 @@ endif
>   
>   ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)
>   
> +ifeq ($(CONFIG_RTE_LIBRTE_EAL),y)
> +LDLIBS += -lrte_eal
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y)
> +LDLIBS += -lrte_malloc
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_MEMPOOL),y)
> +LDLIBS += -lrte_mempool
> +endif
> +
> +ifeq ($(CONFIG_RTE_LIBRTE_RING),y)
> +LDLIBS += -lrte_ring
> +endif
> +
> +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y)
> +LDLIBS += --as-needed
> +endif
> +
>   ifeq ($(CONFIG_RTE_LIBRTE_DISTRIBUTOR),y)
>   LDLIBS += -lrte_distributor
>   endif
> @@ -171,22 +191,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y)
>   LDLIBS += -lethdev
>   endif
>   
> -ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y)
> -LDLIBS += -lrte_malloc
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_MEMPOOL),y)
> -LDLIBS += -lrte_mempool
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_RING),y)
> -LDLIBS += -lrte_ring
> -endif
> -
> -ifeq ($(CONFIG_RTE_LIBRTE_EAL),y)
> -LDLIBS += -lrte_eal
> -endif
> -
>   ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y)
>   LDLIBS += -lrte_cmdline
>   endif