From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 402967EB0 for ; Thu, 16 Apr 2015 11:14:47 +0200 (CEST) Received: by wgyo15 with SMTP id o15so73785136wgy.2 for ; Thu, 16 Apr 2015 02:14:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=CVUn/csBBU6aAa8wvSuNEvFSVHclo40+R7nrureATqs=; b=JrXKOuDtjM3uc5Fxa/flkpuS+KOzANQ9FUplCzvauz6bmKerAQxU83LjKEc6XCxlLz Mwp8ReA48MP/8wPjdoyzdBs7+HnS/bGl6P1OB23Gyue9vgOrHo4S7QOXNLGENvCBxr8W RcL1el/ENwGbt0rrF95LFwcOB3plbwvgELng6VulEMQ0uSrIK+uF0mEDjCRGZEgbKk/m gxOlj/D3UrKi/Vcecq6ViljqrgJBCknbdH5zfNiMWQvFArcAUFLU6vOrg5jw9t3IpJCW sTZxZ3TZEztM7rt3XzKNprxW7n9lHK/IK6j6EPucZUncEKqhiWtymtqnHflXI+AAKS42 b/fQ== X-Gm-Message-State: ALoCoQmOHh/jJsrUuqyZNdyt6WsTwtShCJJz7A5dlYik89Kec0ALUeHOTcxU7pkzW6LmHuNnTss3 X-Received: by 10.180.96.138 with SMTP id ds10mr3135580wib.95.1429175687078; Thu, 16 Apr 2015 02:14:47 -0700 (PDT) Received: from [10.0.0.166] ([212.143.139.214]) by mx.google.com with ESMTPSA id eh5sm10710777wic.20.2015.04.16.02.14.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 02:14:46 -0700 (PDT) Message-ID: <552F7D85.2090002@cloudius-systems.com> Date: Thu, 16 Apr 2015 12:14:45 +0300 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Monjalon , dev@dpdk.org References: <1958525.YbKd0lDtje@xps13> <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/2] ixgbe: fix build with gcc 4.4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 09:14:47 -0000 On 04/15/15 23:49, Thomas Monjalon wrote: > With GCC 4.4.7 from CentOS 6.5, the following errors arise: > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_dev_rx_queue_setup’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for ‘dev_info.driver_name’) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_set_rsc’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for ‘dev_info.driver_name’) > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_recv_pkts_lro_single_alloc’: > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: ‘next_rsc_entry’ may be used uninitialized in this function > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: ‘next_rxe’ may be used uninitialized in this function > > The "missing initializer" warning is a GCC bug which seems fixed in 4.7. > The "may be used uninitialized" warning seems to be another GCC bug and is > workarounded with NULL initialization. > > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > > Signed-off-by: Thomas Monjalon > --- > changes in v2: > - option -Wno-missing-field-initializers for old GCC instead of code workaround > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++-- > mk/toolchain/gcc/rte.vars.mk | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > index f1da9ec..6475c44 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c > @@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, > bool eop; > struct ixgbe_rx_entry *rxe; > struct ixgbe_rsc_entry *rsc_entry; > - struct ixgbe_rsc_entry *next_rsc_entry; > - struct ixgbe_rx_entry *next_rxe; > + struct ixgbe_rsc_entry *next_rsc_entry = NULL; > + struct ixgbe_rx_entry *next_rxe = NULL; -Wno-maybe-uninitialized ? > struct rte_mbuf *first_seg; > struct rte_mbuf *rxm; > struct rte_mbuf *nmb; > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk > index 88f235c..208cddd 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -80,5 +80,10 @@ WERROR_FLAGS += -Wundef -Wwrite-strings > # process cpu flags > include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk > > +# workaround GCC bug with warning "missing initializer" for "= {0}" > +ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) > +WERROR_FLAGS += -Wno-missing-field-initializers > +endif > + > export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF > export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS