From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 719F4C3AA for ; Sun, 19 Apr 2015 10:21:59 +0200 (CEST) Received: by wgyo15 with SMTP id o15so150402682wgy.2 for ; Sun, 19 Apr 2015 01:21:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=qn0GMh4+tDVsZSnql4/shd8EgRMPuwWwZKxQ7gSoi9w=; b=Um57da//UHOH5+EkQExuWzyi4Dd2B4kQU/M+m7TPrkrhJ5NH7TF5dWu2eh6h/fz9X2 nUIjtbtMNvpNZD9UenuR6gEg78OB93Nqj566sZ3cy2DWEYIfjqk+lc3rE6EcIefwILrj JKcgS5IgzpjVG95EHZ3SgqCP8rSwEdd9fmtFTJ8dFb8OOtQHlvr7X+pjjSLaGZx7HKbU FkdT2+e9OSQa8iJ750d66JkxPAwODNTgdaFKQGH2tWiN8B7Za7EnAwt0CJYkTlGC3J5e rbqxIRL9ElKdNvs+8T5mY4EchhseDhi2UiuNUGfqf2q7X5U5TfPcMkzGWVffPk4rSl7R EzjQ== X-Gm-Message-State: ALoCoQkJA2k8WXHlBKvMWq7Zp/EgyNj+GB5UnPHVXKQlEXCzINd7gUU/5WHoeYb5jeb/MmFI32vm X-Received: by 10.180.7.169 with SMTP id k9mr13018797wia.70.1429431719262; Sun, 19 Apr 2015 01:21:59 -0700 (PDT) Received: from [10.0.0.166] ([212.143.139.214]) by mx.google.com with ESMTPSA id e2sm10104989wij.5.2015.04.19.01.21.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Apr 2015 01:21:58 -0700 (PDT) Message-ID: <553365A5.20405@cloudius-systems.com> Date: Sun, 19 Apr 2015 11:21:57 +0300 From: Vlad Zolotarov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Monjalon , dev@dpdk.org References: <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com> <1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: <1429222237-8002-1-git-send-email-thomas.monjalon@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] mk: fix build with gcc 4.4 and clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 08:21:59 -0000 On 04/17/15 01:10, Thomas Monjalon wrote: > With GCC 4.4.7 from CentOS 6.5, the following errors arise: > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_dev_rx_queue_setup': > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for 'dev_info.driver_name') > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_set_rsc': > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for 'dev_info.driver_name') > > lib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function 'ixgbe_recv_pkts_lro_single_alloc': > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: 'next_rsc_entry' may be used uninitialized in this function > lib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: 'next_rxe' may be used uninitialized in this function > > The "missing initializer" warning is a GCC bug which seems fixed in 4.7. > The same warning is thrown by clang. > The "may be used uninitialized" warning is another GCC bug which seems fixed in 4.7. > > Fixes: 8eecb3295aed ("ixgbe: add LRO support") > > Signed-off-by: Thomas Monjalon Acked-by: Vlad Zolotarov > --- > changes in v2: > - option -Wno-missing-field-initializers for old GCC instead of code workaround > changes in v3: > - option -Wno-missing-field-initializers for clang > - option -Wno-uninitialized for old GCC instead of code workaround (=NULL) > - remove redundants -Wno-uninitialized from ixgbe Makefile > > lib/librte_pmd_ixgbe/Makefile | 4 ---- > mk/toolchain/clang/rte.vars.mk | 3 +++ > mk/toolchain/gcc/rte.vars.mk | 9 +++++++++ > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/Makefile b/lib/librte_pmd_ixgbe/Makefile > index ae36202..fbf6966 100644 > --- a/lib/librte_pmd_ixgbe/Makefile > +++ b/lib/librte_pmd_ixgbe/Makefile > @@ -76,10 +76,6 @@ ifeq ($(shell test $(GCC_VERSION) -ge 50 && echo 1), 1) > CFLAGS_ixgbe_common.o += -Wno-logical-not-parentheses > endif > > -ifeq ($(shell test $(GCC_VERSION) -le 46 && echo 1), 1) > -CFLAGS_ixgbe_x550.o += -Wno-uninitialized > -CFLAGS_ixgbe_phy.o += -Wno-uninitialized > -endif > endif > > # > diff --git a/mk/toolchain/clang/rte.vars.mk b/mk/toolchain/clang/rte.vars.mk > index 40cb389..245ea7e 100644 > --- a/mk/toolchain/clang/rte.vars.mk > +++ b/mk/toolchain/clang/rte.vars.mk > @@ -72,5 +72,8 @@ WERROR_FLAGS += -Wundef -Wwrite-strings > # process cpu flags > include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk > > +# workaround clang bug with warning "missing field initializer" for "= {0}" > +WERROR_FLAGS += -Wno-missing-field-initializers > + > export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF > export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS > diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk > index 88f235c..0f51c66 100644 > --- a/mk/toolchain/gcc/rte.vars.mk > +++ b/mk/toolchain/gcc/rte.vars.mk > @@ -80,5 +80,14 @@ WERROR_FLAGS += -Wundef -Wwrite-strings > # process cpu flags > include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk > > +# workaround GCC bug with warning "missing initializer" for "= {0}" > +ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) > +WERROR_FLAGS += -Wno-missing-field-initializers > +endif > +# workaround GCC bug with warning "may be used uninitialized" > +ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) > +WERROR_FLAGS += -Wno-uninitialized > +endif > + > export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF > export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS