From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AF3ED376C for ; Mon, 20 Apr 2015 18:51:17 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 20 Apr 2015 09:51:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,610,1422950400"; d="scan'208";a="682869911" Received: from venky-cp-ivb2.jf.intel.com (HELO [134.134.172.156]) ([134.134.172.156]) by orsmga001.jf.intel.com with ESMTP; 20 Apr 2015 09:51:16 -0700 Message-ID: <55352D47.8010906@intel.com> Date: Mon, 20 Apr 2015 09:45:59 -0700 From: Venky Venkatesan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1429539103-15885-1-git-send-email-thomas.monjalon@6wind.com> <20150420163348.GA19573@hmsreliant.think-freely.org> In-Reply-To: <20150420163348.GA19573@hmsreliant.think-freely.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: remove old flow director API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 16:51:18 -0000 On 04/20/2015 09:33 AM, Neil Horman wrote: > On Mon, Apr 20, 2015 at 04:11:43PM +0200, Thomas Monjalon wrote: >> It's time to remove this old API. >> It seems some work is still needed to rely only on eth_ctrl API. >> At least ixgbe, i40e and testpmd must be fixed. >> Jingjing, do you think it's possible to remove all these structures >> from rte_ethdev.h? >> >> Thanks >> > NAK. > > I'm certainly not opposed to removing the API's if they are truly no longer > needed. But they have been codified as part of the ABI, so the deprecation > schedule needs to be followed. Given what you've said above, it seems like that > might be worthwhile anyway, as it will provide the needed runway to allow users > to convert to the new API. > > Neil +1 NAK. Agree with Neil.