DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Bernard Iremonger <bernard.iremonger@intel.com>,
	thomas@monjalon.net, ferruh.yigit@intel.com,
	keith.wiles@intel.com
Subject: Re: [dpdk-dev] [PATCH] doc: document all EAL parameters in one place
Date: Mon, 19 Nov 2018 10:15:21 +0000	[thread overview]
Message-ID: <553833b2-1920-1240-1deb-26693ac01b8c@intel.com> (raw)
In-Reply-To: <6c5eddbb2339d917a9b67666499ae11ca8aa344b.1542386956.git.anatoly.burakov@intel.com>

On 16-Nov-18 4:52 PM, Anatoly Burakov wrote:
> Currently, the most complete (but still incomplete) user guide for
> EAL command-line parameters resides in user guide for testpmd.
> This is wrong on multiple levels, and should not be the case.
> 
> To fix it, we have to create a document that lists all supported
> EAL command-line arguments. However, because different platforms
> support different subsets of available EAL parameters, instead of
> creating a single file, we will create a common file in
> doc/guides/common containing documentation for EAL parameters
> that are supported on all of our supported platforms (Linux and
> FreeBSD at the time of this writing).
> 
> We will then include this document in the Getting Started guides
> for all supported platforms, so that any changes made to
> documentation for commonly supported EAL parameters will be
> reflected in Getting Started guides for all platforms.
> 
> This patch also removes EAL parameters documentation from the
> testpmd user guide, and instead adds references to the newly
> created documents in both testpmd user guides and in sample
> applications guide.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> 
> Notes:
>      Here, "supported" is defined not as "doesn't produce error
>      on a particular platform, but rather is defined as "actually
>      works according to current codebase". All command-line
>      options have been traced through code to determine whether
>      they actually do anything.
>      
>      As a result, even though some command-line options (such as
>      "--vmware-tsc-map") are handled in eal_common_options (and
>      thus are supposed to be supported on all platforms), they
>      are nevertheless marked as Linux-specific. I believe this
>      is a good standard to follow.
>      
>      It would also be good to include links to relevant PG
>      sections for each parameters, but that can be done in
>      the future. This is a good enough start, i think.
>      
>      Also, currently, this breaks our pdf doc build because
>      i've added a "common" directory, and our PDF generator
>      expects an index.rst to be in there, even though this
>      directory is not supposed to be an actual document. I
>      would kindly request community's advice on how to best
>      resolve this situation.
>      
>      Things that i can think of myself:
>      - Put the common EAL flags somewhere in the existing
>        directories (we don't have anything appropriate for
>        that, but the last resolt would be something like
>        Linux GSG directory)
>      - Hack our build system to not create a "common" PDF
>        file and skip this directory altogether
>      - Put this file outside of doc/guides (doc/common?)
> 

The above problem with pdf doc build still exists and needs to be solved 
before this patch is integrated. Unfortunately, my LaTeX-fu is lacking, 
so i'd really like some help here :)

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2018-11-19 10:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 16:52 Anatoly Burakov
2018-11-16 17:25 ` Ferruh Yigit
2018-11-17  5:15   ` Rami Rosen
2018-11-19 11:07     ` Mcnamara, John
2018-11-19 10:15 ` Burakov, Anatoly [this message]
2018-11-19 13:10 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-19 13:14   ` Burakov, Anatoly
2018-11-22 17:27   ` Thomas Monjalon
2018-11-23  9:20     ` Burakov, Anatoly
2018-11-23  9:54       ` Thomas Monjalon
2018-11-23 10:51   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553833b2-1920-1240-1deb-26693ac01b8c@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=keith.wiles@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).