From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by dpdk.org (Postfix) with ESMTP id DD1D2376C for ; Thu, 23 Apr 2015 06:23:35 +0200 (CEST) Received: by pabtp1 with SMTP id tp1so7268000pab.2 for ; Wed, 22 Apr 2015 21:23:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=6i4o7kXd1HZZStlpK+aoyJAcuTTAQ3HPcDEpUl+K1uk=; b=OG8lsc0qZu3z/35VsEky7i5P37AOsp26vz8+7vrsqq+zV4lkShs7mi6Ft69H+yOQoE B+J/mZ69IoE2XNvGGmxWft9nVNJEJhJexutUdP7glUrq+jwzo2HXyBEKSbn8rTQHeKDx dsWmVxV621Vd26wvxcYLknj5o/humZ+jY3qI+0MPYJJgHY0FN14FCOlMH0//DKczatrD rnu0ICKDp11iGkE/wV0jkT5pp1IH5eahF+dYbsiuK15ICYf9Si8zSZDdDGaSjagG9HhV Je1JI8n2CTtm6HkczDwNjCNah8jGmPTQxtgRXrjV8A5a6H4/ih9njVN76CYcpxRZ0+RK MM+A== X-Gm-Message-State: ALoCoQllXqfN4jPgtaxmsztb+NB04v1kHW+6ntynmJCvcDKCdnYP46OVy3cZMQHfQXeUZqa1YLdi X-Received: by 10.68.132.194 with SMTP id ow2mr1641471pbb.51.1429763015031; Wed, 22 Apr 2015 21:23:35 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id dk5sm6577979pdb.88.2015.04.22.21.23.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2015 21:23:34 -0700 (PDT) Message-ID: <553873C5.1000909@igel.co.jp> Date: Thu, 23 Apr 2015 13:23:33 +0900 From: Tetsuya Mukawa User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Iremonger, Bernard" , "dev@dpdk.org" References: <1426584645-28828-7-git-send-email-mukawa@igel.co.jp> <1427445553-3151-1-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A0FF82@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A0FF82@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2015 04:23:36 -0000 On 2015/04/21 22:15, Iremonger, Bernard wrote: >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] >> Sent: Friday, March 27, 2015 8:39 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand@6wind.com; Tetsuya Mukawa >> Subject: [PATCH v3 0/5] Clean up pci uio implementations >> >> This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio >> implementation of linuxapp and bsdapp, and moving consolidated functions in eal common. >> Because of above, this patch set tries to implement linuxapp and bsdapp almost same. >> Actual consolidations will be done later patch set. >> >> PATCH v3 changes: >> - Squash patches related with pci_map_resource(). >> - Free maps[].path to easy to understand. >> (Thanks to Iremonger, Bernard) >> - Close fds opened in this function. >> - Remove unused path variable from mapped_pci_resource structure. >> >> PATCH v2 changes: >> - Move 'if-condition' to later patch series. >> - Fix memory leaks of path. >> - Fix typos. >> (Thanks to David Marchand) >> - Fix commit title and body. >> - Fix pci_map_resource() to handle MAP_FAILED. >> (Thanks to Iremonger, Bernard) >> >> Changes: >> - This patch set is derived from below. >> "[PATCH v2] eal: Port Hotplug support for BSD" >> - Set cfg_fd as -1, when cfg_fd is closed. >> (Thanks to Iremonger, Bernard) >> - Remove needless coding style fixings. >> - Fix coding style of if-else condition. >> (Thanks to Richardson, Bruce) >> >> >> >> Tetsuya Mukawa (5): >> eal: Fix coding style of eal_pci.c and eal_pci_uio.c >> eal: Close file descriptor of uio configuration >> eal: Fix memory leaks and needless increment of pci_map_addr >> eal/bsdapp: Change names of pci related data structure >> eal: Fix uio mapping differences between linuxapp and bsdapp >> >> lib/librte_eal/bsdapp/eal/eal_pci.c | 166 +++++++++++++++++------------ >> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 91 +++++++++------- >> 3 files changed, 154 insertions(+), 104 deletions(-) >> >> -- >> 1.9.1 > Series > Acked-by: Bernard Iremonger Hi Bernard, Thanks for your checking. It seems I need to rebase this patches for latest matser branch. So I will update and submit it soon. Regards, Tetsuya