From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 942972A5B
 for <dev@dpdk.org>; Thu, 23 Apr 2015 09:25:16 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 23 Apr 2015 00:25:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,629,1422950400"; d="scan'208";a="684389168"
Received: from unknown (HELO [10.217.248.56]) ([10.217.248.56])
 by orsmga001.jf.intel.com with ESMTP; 23 Apr 2015 00:25:15 -0700
Message-ID: <55389E44.8030603@intel.com>
Date: Thu, 23 Apr 2015 09:24:52 +0200
From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: dev@dpdk.org
References: <1429716828-19012-1-git-send-email-rkerur@gmail.com>
 <1429716828-19012-2-git-send-email-rkerur@gmail.com>
In-Reply-To: <1429716828-19012-2-git-send-email-rkerur@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] Implement memcmp using AVX/SSE instructio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2015 07:25:17 -0000

On 2015-04-22 17:33, Ravi Kerur wrote:
> +/**
> + * Compare bytes between two locations. The locations must not overlap.
> + *
> + * @note This is implemented as a macro, so it's address should not be taken
> + * and care is needed as parameter expressions may be evaluated multiple times.
> + *
> + * @param src_1
> + *   Pointer to the first source of the data.
> + * @param src_2
> + *   Pointer to the second source of the data.
> + * @param n
> + *   Number of bytes to compare.
> + * @return
> + *   true if equal otherwise false.
> + */
> +static inline bool
> +rte_memcmp(const void *src_1, const void *src,
> +		size_t n) __attribute__((always_inline));
You are exposing this as public API, so I think you should follow 
description bellow or not call this _memcmp_

int memcmp(const void *s1, const void *s2, size_t n);

The memcmp() function returns an integer less than, equal  to,  or 
greater  than
        zero  if  the  first  n  bytes  of s1 is found, respectively, to 
be less than, to
        match, or be greater than the first n bytes of s2.

-- 
Pawel