From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergio.gonzalez.monroy@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E5001C80E
 for <dev@dpdk.org>; Wed, 29 Apr 2015 13:08:56 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 29 Apr 2015 04:08:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,670,1422950400"; d="scan'208";a="717697731"
Received: from unknown (HELO [10.237.220.41]) ([10.237.220.41])
 by fmsmga002.fm.intel.com with ESMTP; 29 Apr 2015 04:08:54 -0700
Message-ID: <5540BBC6.3090008@intel.com>
Date: Wed, 29 Apr 2015 12:08:54 +0100
From: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1430240597-26782-1-git-send-email-keith.wiles@intel.com>
 <CA+PrjLEFpvOLS4rn=0MOOvXrW-rXK28Q3H+peq1Wrobg-kLtWA@mail.gmail.com>
In-Reply-To: <CA+PrjLEFpvOLS4rn=0MOOvXrW-rXK28Q3H+peq1Wrobg-kLtWA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Apr 2015 11:08:57 -0000

On 29/04/2015 11:12, Thomas Monjalon wrote:
> Hi Keith,
>
> Thanks for trying to improve maintainability.
>
> It seems this is the second version of your patch.
> Please add v2 prefix and a changelog to ease review and
> patch management.
> As you probably know, it is explained here:
>      http://dpdk.org/dev#send
Hi Thomas,

Just to clarify as I tend to use RFC PATCH as well, do we still mark it 
as v2 even though the first patch was an RFC PATCH?

Sergio
> 2015-04-28 19:03 GMT+02:00 Keith Wiles <keith.wiles@intel.com>:
>> Trying to simplify the ifdefs in rte.app.mk to make the code
>> more readable and maintainable by moving LDLIBS variable to use
>> the same style as LDLIBS-y being used in the rest of the code.
>>
>> Added a new variable called EXTRA_LDLIBS to be used by example apps
>> instead of using LDLIBS directly.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>