DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH] eal: add asprintf() function for Windows
Date: Fri, 27 Jun 2025 12:19:13 +0200	[thread overview]
Message-ID: <5542814.uBEoKPz9u1@thomas> (raw)
In-Reply-To: <20250612144648.GB3279@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

12/06/2025 16:46, Andre Muezerie:
> On Thu, Jun 12, 2025 at 02:41:05AM +0200, Thomas Monjalon wrote:
> > 06/05/2025 03:43, Andre Muezerie:
> > > The asprintf function is not part of the C standard library but is a
> > > GNU extension commonly available in Unix-like systems. It dynamically
> > > allocates memory to store the formatted output string, similar to
> > > sprintf, but avoids buffer overflow issues by automatically sizing
> > > the buffer.
> > > 
> > > Instead of rewriting it or coming up with some other replacement, this
> > > patch makes use of the implementation provided by Neved4.
> > 
> > Why not using eal_asprintf()?
> > 
> 
> There are many calls being made directly to asprintf() which made me
> believe there wasn’t an equivalent available for Windows yet.
> 
> Thanks for pointing out that is not the case.
> 
> I’ll make the necessary changes to call eal_asprintf() instead.

Thanks to the define in lib/eal/common/eal_private.h,
asprintf should automatically call eal_asprintf on Windows.




      reply	other threads:[~2025-06-27 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06  1:43 Andre Muezerie
2025-06-12  0:41 ` Thomas Monjalon
2025-06-12 14:46   ` Andre Muezerie
2025-06-27 10:19     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5542814.uBEoKPz9u1@thomas \
    --to=thomas@monjalon.net \
    --cc=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).