From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B336AA034E; Tue, 19 Nov 2019 17:05:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0886FB62; Tue, 19 Nov 2019 17:05:42 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 28D712AB for ; Tue, 19 Nov 2019 17:05:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DC802632; Tue, 19 Nov 2019 11:05:35 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 19 Nov 2019 11:05:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vNuz//s6LruuXOl38aHrpHVnNLlB7Jtijx4PCwkGJ4E=; b=AFQ65yKk2/10 eyGA69rwiAyH50dhRh56AO1SQpY352uLUi+Y3BWX7ja3CSzhmSPGTvMLnjPMYo3P OhjVLYPj6fXw2Fe+0PGUTbe1Emjedj1xrJSgori4pZKPXBAvIBB9Dvgbp4UTeX5w ZwywSGE0dX8IbeIZ7FtQBm9dfrEwiBo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vNuz//s6LruuXOl38aHrpHVnNLlB7Jtijx4PCwkGJ 4E=; b=WeiJYUiN5ZKAAyA6SR8CO24Mv03B9+GLFZKgRKcAymFwUxZsnIw7jlTI6 ydOKaUXyQ0xeGvqWMsFRaQoi6S0u8KmIF2bpZXN2BrbBjlQfX47QdcQ4vYiTKbHl 9a4yibhc2sp9xExbWAxrF+TQaYEZKpyJA9uk5kg+Er4L1ezGw/Thax3qsJSo6LHE OSuj2cfL6YFuR02YYwVw3TBlqi6Y1ZFDjTX3JVerFobGJYpBjGRv4hNvBfNPt/0F Su6B/lHlUDzQBkiRFVDSfOzWO31CmJqLWFsk7si+R7RQDKnBsj0aqBBWw3RXgtU4 qQfhngAHRMxB0NJIVMcLAFY+j5Rzw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudegkedgkeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BC65306005E; Tue, 19 Nov 2019 11:05:33 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Pawel Modrak , john.mcnamara@intel.com, ray.kinsella@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com Date: Tue, 19 Nov 2019 17:05:30 +0100 Message-ID: <5543784.Ic5mrqJpG7@xps> In-Reply-To: References: <6374065.o3Opl9toy7@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/11/2019 16:38, Burakov, Anatoly: > On 19-Nov-19 2:01 PM, Thomas Monjalon wrote: > > 08/11/2019 17:25, Anatoly Burakov: > >> From: Pawel Modrak > >> > >> Add a script that automatically merges all stable ABI's under one > >> ABI section with the new version, while leaving experimental > >> section exactly as it is. > >> > >> Signed-off-by: Pawel Modrak > >> Signed-off-by: Anatoly Burakov > >> Acked-by: Bruce Richardson > >> --- > >> --- /dev/null > >> +++ b/buildtools/update_version_map_abi.py > >> +""" > >> +A Python program to update the ABI version and function names in a DPDK > >> +lib_*_version.map file. Called from the buildtools/update_abi.sh utility. > >> +""" > > > > Clearly this script is doing more than updating a version number and names. > > I already see more in the commit log. > > Please would you like to add something in this description? > > Not sure what you're referring to. That's exactly what it's doing. What > else is there that i'm missing? "merges all stable ABI's under one ABI section" "while leaving experimental section exactly as it is" I think this needs to be in the comment at the top of the file, so we have an introduction for the code in the rest of the file.