From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0B101A04BB;
	Tue,  6 Oct 2020 13:05:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4F47A2952;
	Tue,  6 Oct 2020 13:05:19 +0200 (CEST)
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id C812A11A4
 for <dev@dpdk.org>; Tue,  6 Oct 2020 13:05:16 +0200 (CEST)
IronPort-SDR: O7Hd3SkKxRINU1kLr8mi4LclTZQz5RC+rGk7b67Ezr/Pk3ev6RFetWQA9Nv5TNK5p1URbZR3Wn
 piCA0eJxxXSw==
X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="161827895"
X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="161827895"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Oct 2020 04:05:14 -0700
IronPort-SDR: lyvrg0G3yaf84E3V5xKOEIDk5fyid3jL4momMvP39whXPJz4zLJQXiAKi/f/s9KjrFK+JFxPHn
 yyUgCtkwAfjg==
X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342195792"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102])
 ([10.213.241.102])
 by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 06 Oct 2020 04:05:14 -0700
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
References: <20201005120910.189343-1-jiawenwu@trustnetic.com>
 <20201005120910.189343-40-jiawenwu@trustnetic.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <554633d9-fb3f-e21c-2744-8186e5b62ead@intel.com>
Date: Tue, 6 Oct 2020 12:05:12 +0100
MIME-Version: 1.0
In-Reply-To: <20201005120910.189343-40-jiawenwu@trustnetic.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2 39/56] net/txgbe: add process mailbox
 operation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/5/2020 1:08 PM, Jiawen Wu wrote:
> From: jiawenwu <jiawenwu@trustnetic.com>
> 
> Add check operation for vf function level reset, mailbox messages and ack from vf. Waiting to process the messages.
> 
> Signed-off-by: jiawenwu <jiawenwu@trustnetic.com>

<...>

> --- /dev/null
> +++ b/drivers/net/txgbe/rte_pmd_txgbe.c
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2015-2020
> + */
> +
> +#include <rte_ethdev_driver.h>
> +
> +#include "base/txgbe.h"
> +#include "txgbe_ethdev.h"
> +#include "rte_pmd_txgbe.h"
> +

Why 'rte_pmd_txgbe.c' added at all? As far as I can see there is no PMD specific 
API, so no need to have this file.