From: Thomas Monjalon <thomas@monjalon.net>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>,
andrew.rybchenko@oktetlabs.ru, qi.z.zhang@intel.com,
ajit.khaparde@broadcom.com, jerinj@marvell.com,
viacheslavo@nvidia.com
Subject: Re: [dpdk-dev] Question about RSS offload types
Date: Wed, 03 Nov 2021 09:04:44 +0100 [thread overview]
Message-ID: <5547595.6aP3pihIX3@thomas> (raw)
In-Reply-To: <02f1634c-bd47-24f7-858b-80b3e006ea73@huawei.com>
03/11/2021 02:35, lihuisong (C):
> Below macros are defined for RSS offload types in rte_ethdev.h.
>
> #define *ETH_RSS_IPV4 * (1ULL << 2)
> #define ETH_RSS_FRAG_IPV4 (1ULL << 3)
> #define ETH_RSS_NONFRAG_IPV4_TCP (1ULL << 4)
> #define ETH_RSS_NONFRAG_IPV4_UDP (1ULL << 5)
> #define ETH_RSS_NONFRAG_IPV4_SCTP (1ULL << 6)
> #define *ETH_RSS_NONFRAG_IPV4_OTHER* (1ULL << 7)
>
> What types of packets do ETH_RSS_IPV4 and ETH_RSS_NONFRAG_IPV4_OTHER refer
> to respectively, and what are the differences between them?
I understand why you have this question,
but we should not have this kind of basic question if the API
was properly documented.
Please let's check all PMDs have the same expectation regarding
these values and let's document it with Doxygen comments.
PMD maintainers, how do you understand and implement these values?
next prev parent reply other threads:[~2021-11-03 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 1:35 lihuisong (C)
2021-11-03 8:04 ` Thomas Monjalon [this message]
2021-11-11 8:40 ` lihuisong (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547595.6aP3pihIX3@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=lihuisong@huawei.com \
--cc=qi.z.zhang@intel.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).