From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37EB8A0562; Thu, 15 Apr 2021 00:50:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19B73161D9C; Thu, 15 Apr 2021 00:50:49 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 03A0E161D9B for ; Thu, 15 Apr 2021 00:50:47 +0200 (CEST) IronPort-SDR: wK6xrWX28jZ7tM+ySq3yWM26OorcNW55lITsKG1+rhDl06WSHdyATMZO3dyvUDJcZFl12Wg+9C qpepokChpKCg== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="280066611" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="280066611" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 15:50:46 -0700 IronPort-SDR: wRPnhsX+5xlRcX185Z0roRfzRCrDkecVsKLCDBv8C9E5zD1gHLhM7bQT/4DVhIVidhMLC2C3OP WtKJwMbRqJig== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="532937257" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 15:50:46 -0700 To: Dmitry Kozlyuk , dev@dpdk.org References: <20210410224732.20234-1-dmitry.kozliuk@gmail.com> <20210414220651.28691-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <554cb3c9-4d12-5de6-5f65-d05a99e67d0e@intel.com> Date: Wed, 14 Apr 2021 15:50:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210414220651.28691-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v10 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/14/2021 3:06 PM, Dmitry Kozlyuk wrote: > On Windows, EAL contains two sets of functions and macros for POSIX > compatibility: and a networking shim (socket headers). > The latter conflicts with system headers and should not exist. > Exposing the former from EAL can break consumer own POSIX compatibility > layer and is against standards in general. Hide these symbols from > external consumers, while keeping them available for DPDK code. > > v10: > * Fix examples that build on Windows. > v9: > * Fix missing include in rte_common_log.c. > (This will happen again. Going to add a checkpatch test > after this series is merged.) > > Dmitry Kozlyuk (4): > eal/windows: hide asprintf() shim > eal: make OS shims internal > net: work around s_addr macro on Windows > net: provide IP-related API on any OS > > drivers/bus/pci/private.h | 4 +- > drivers/bus/vdev/vdev_private.h | 2 + > drivers/common/mlx5/mlx5_common.h | 1 + > drivers/net/i40e/i40e_ethdev.c | 1 + > drivers/net/i40e/i40e_fdir.c | 1 + > drivers/net/mlx5/mlx5.h | 1 - > drivers/net/mlx5/mlx5_flow.c | 4 +- > drivers/net/mlx5/mlx5_flow.h | 3 +- > drivers/net/mlx5/mlx5_mac.c | 1 - > examples/cmdline/commands.c | 5 -- > examples/cmdline/parse_obj_list.c | 2 - > examples/flow_filtering/main.c | 1 - > examples/l2fwd/main.c | 1 - > examples/link_status_interrupt/main.c | 1 - > examples/service_cores/main.c | 4 +- > lib/librte_cmdline/cmdline.c | 5 -- > lib/librte_cmdline/cmdline_os_windows.c | 2 - > lib/librte_cmdline/cmdline_parse.c | 2 - > lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 -- > lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 -- > lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- > lib/librte_cmdline/cmdline_private.h | 1 + > lib/librte_cmdline/cmdline_socket.c | 4 - > lib/librte_eal/common/eal_common_config.c | 1 - > lib/librte_eal/common/eal_common_errno.c | 4 + > lib/librte_eal/common/eal_common_log.c | 1 + > lib/librte_eal/common/eal_common_options.c | 2 +- > lib/librte_eal/common/eal_common_timer.c | 4 +- > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_private.h | 11 +++ > lib/librte_eal/freebsd/include/rte_os_shim.h | 14 +++ > lib/librte_eal/linux/include/rte_os_shim.h | 14 +++ > lib/librte_eal/windows/eal.c | 30 +++++++ > lib/librte_eal/windows/eal_hugepages.c | 1 - > lib/librte_eal/windows/eal_lcore.c | 1 - > lib/librte_eal/windows/eal_memalloc.c | 1 - > lib/librte_eal/windows/include/arpa/inet.h | 30 ------- > lib/librte_eal/windows/include/netinet/in.h | 38 -------- > lib/librte_eal/windows/include/netinet/ip.h | 10 --- > lib/librte_eal/windows/include/rte_os.h | 92 +------------------- > lib/librte_eal/windows/include/rte_os_shim.h | 36 ++++++++ > lib/librte_eal/windows/include/sys/socket.h | 24 ----- > lib/librte_ethdev/ethdev_private.h | 2 + > lib/librte_ethdev/rte_ethdev.c | 12 +-- > lib/librte_ethdev/rte_ethdev_core.h | 1 - > lib/librte_kvargs/rte_kvargs.c | 1 + > lib/librte_net/rte_ether.h | 26 ++++-- > lib/librte_net/rte_ip.h | 7 ++ > lib/librte_net/rte_net.c | 1 + > 49 files changed, 167 insertions(+), 258 deletions(-) > create mode 100644 lib/librte_eal/freebsd/include/rte_os_shim.h > create mode 100644 lib/librte_eal/linux/include/rte_os_shim.h > delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h > delete mode 100644 lib/librte_eal/windows/include/netinet/in.h > delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h > create mode 100644 lib/librte_eal/windows/include/rte_os_shim.h > delete mode 100644 lib/librte_eal/windows/include/sys/socket.h Thanks, Dmitry. Acked-by: Ranjit Menon