From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id BBE61C3CA
 for <dev@dpdk.org>; Mon, 11 May 2015 07:16:05 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 10 May 2015 22:16:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,404,1427785200"; d="scan'208";a="727030816"
Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.47])
 ([10.239.66.47])
 by orsmga002.jf.intel.com with ESMTP; 10 May 2015 22:16:05 -0700
Message-ID: <55503B12.9090307@intel.com>
Date: Mon, 11 May 2015 13:16:02 +0800
From: "Liang, Cunming" <cunming.liang@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com>	<1425012976-10173-1-git-send-email-cunming.liang@intel.com>	<1425012976-10173-8-git-send-email-cunming.liang@intel.com>
 <20150320155108.55f836bf@uryu.home.lan>
In-Reply-To: <20150320155108.55f836bf@uryu.home.lan>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 7/8] igb: enable rx queue interrupts for PF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2015 05:16:06 -0000



On 3/21/2015 4:51 AM, Stephen Hemminger wrote:
> On Fri, 27 Feb 2015 12:56:15 +0800
> Cunming Liang <cunming.liang@intel.com> wrote:
>
>>   
>>   /*
>> + * It clears the interrupt causes and enables the interrupt.
>> + * It will be called once only during nic initialized.
>> + *
>> + * @param dev
>> + *  Pointer to struct rte_eth_dev.
>> + *
>> + * @return
>> + *  - On success, zero.
>> + *  - On failure, a negative value.
>> + */
>> +static int eth_igb_rxq_interrupt_setup(struct rte_eth_dev *dev)
>> +{
>> +
> This function should be void
> It always succeeds and the caller just not check the return value.
>
> If you did this in one driver, I bet other drivers have same problem.
[LCM] The previous reason probably to keep consistent with 
lsc_interrupt_setup. But I think it's reasonable to change to void.
I'm considering another thing is that does is necessary to have 
condition rxq_interrupt_setup by intr_conf.rxq.
As even without it, we can manually turn on rxq interrupt by API 
rte_eth_dev_rx_intr_enable.