From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 47909C386 for ; Thu, 28 Jan 2016 09:23:05 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id l66so14405775wml.0 for ; Thu, 28 Jan 2016 00:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=2vpoxOfWHcMNTRrUTGCEqWpqBCtYBg9PGEJlqj9ObWE=; b=zAaYI9aBdeZPGbLTurf6jw19JFWxaUBXu08IuUPRKDCpAqd5YCTNI8ULgMLYiaagbR HGVVaNbW6CMT/zqI81cai+ERC/bezYhHVk9xmN/GYOTW2y/Z8e3LRcjmdFpT7eA/Y2sb FfMJ00tu5Sd2DxVAookIAdd6H7S818AXdGNlDcIn4b5nQ6IpyZHeFHeFsuqjAxprla9k tIoQYRtCu62PyZGxoK+7PSn9GN+bNioGMP8NLN7BIkEc8lskj7V//AmLhrWTEWDg6rD7 UP1POOY3uasnWZDLF1fZNRp2sKmSX38btRLxJr+Uo9k8obZ44tai13uDnYUhO/thLViP 2QAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2vpoxOfWHcMNTRrUTGCEqWpqBCtYBg9PGEJlqj9ObWE=; b=F6xlOLsW00Uw+mJjyOJVai3lqKg4pRY3rxvR6/u3/18MwX/AwhIiB5JmD42v9DcxsQ bVV7Rxectc+ueHBgyvzX/QufwXzuhVVQFJPYY8Aayr+AUJfR3bT98xkU0jALakRIquAm YfE7C8qbG42utxBoZcXHEdtG+kuoPODkBZFSJgqdlOug9c0HY8+MibaSneEv0fV5kSz0 FgWSHu2jT/UZdKN3UxzITnudJiXYK1mf63fdDPOSQpSVIzbetPqTs0EnuCHHqydv9QWz Lh+iA67A/07vECqdDPa+rTdH4HtV9VHHgLODixGWEHLJJsAdrSCuyKnnOqHRq247kLCQ eE8A== X-Gm-Message-State: AG10YORqkgiltoXA8H80hHnQmO4LgG4ldrJw/YSbQigGrf01SytbEqO21Jh3vbDej5xorlmy X-Received: by 10.28.158.194 with SMTP id h185mr1774310wme.48.1453969385109; Thu, 28 Jan 2016 00:23:05 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id a126sm1693410wmh.0.2016.01.28.00.23.04 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jan 2016 00:23:04 -0800 (PST) From: Thomas Monjalon To: Xutao Sun Date: Thu, 28 Jan 2016 09:21:54 +0100 Message-ID: <5550736.IEy5vK2CRV@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1453966217-10510-2-git-send-email-xutao.sun@intel.com> References: <1453706722-29427-1-git-send-email-xutao.sun@intel.com> <1453966217-10510-1-git-send-email-xutao.sun@intel.com> <1453966217-10510-2-git-send-email-xutao.sun@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/4] lib/ether: optimize the 'rte_eth_tunnel_filter_conf' structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 08:23:05 -0000 2016-01-28 15:30, Xutao Sun: > Change the fields of outer_mac and inner_mac from pointer to struct in order to keep the code's readability. [...] > - tunnel_filter_conf.outer_mac = &res->outer_mac; > - tunnel_filter_conf.inner_mac = &res->inner_mac; > + (void)rte_memcpy(&tunnel_filter_conf.outer_mac, &res->outer_mac, > + ETHER_ADDR_LEN); > + (void)rte_memcpy(&tunnel_filter_conf.inner_mac, &res->inner_mac, > + ETHER_ADDR_LEN); The (void) casting is useless here. > --- a/lib/librte_ether/rte_eth_ctrl.h > +++ b/lib/librte_ether/rte_eth_ctrl.h > @@ -280,8 +280,8 @@ enum rte_tunnel_iptype { > * Tunneling Packet filter configuration. > */ > struct rte_eth_tunnel_filter_conf { > - struct ether_addr *outer_mac; /**< Outer MAC address filter. */ > - struct ether_addr *inner_mac; /**< Inner MAC address filter. */ > + struct ether_addr outer_mac; /**< Outer MAC address filter. */ > + struct ether_addr inner_mac; /**< Inner MAC address filter. */ It is an API change. Please remove the deprecation notice and update the release notes in this patch (atomically).