From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CF8845A1F for ; Tue, 12 May 2015 16:36:54 +0200 (CEST) Received: by wgin8 with SMTP id n8so12441628wgi.0 for ; Tue, 12 May 2015 07:36:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=dhwHQqX+rGEJ59wJc+WTAw0fWU9krIJ6lgRUEeSdJGo=; b=aPvO6ukK7CMDpqwq2Vr32uXlNHSu5SvhlXF9F0dvWbNmiNj+dYosN1+iVv6PxSKzDD drZ1INb3XzIP4zKLr+T/0+4HibuAjNH9SSQtPJ73RrX0Bgh8fn0TpsTFpnl340+tr0R1 vrPPrhItzsX/6k8bfSa5CkRdnSfUSs/DXRiH8orD0aI+bIp0Dv/f60SXj87CEKfs0vIk opRxXduA9AZzKzXXbyyt0vb09ie92eLqweIPxwaqA4acyZ692W4j0cNV//Zol45vOUda sTu63UNOBQu59kZIFMWvWLhWJWXJ62okErq1zI4YICApL81d+1+zE9KbJK0bXGzyaaoX yQTQ== X-Gm-Message-State: ALoCoQm+bMs6mkgcTUUtYbejMaooThu51ki2yoMaw71O53hz84Ur6qRYI0DY5k7757pAx8vk8MEx X-Received: by 10.180.106.70 with SMTP id gs6mr29905068wib.36.1431441414509; Tue, 12 May 2015 07:36:54 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id ng5sm3154323wic.24.2015.05.12.07.36.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 07:36:53 -0700 (PDT) Message-ID: <55521003.1080805@6wind.com> Date: Tue, 12 May 2015 16:36:51 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Pawel Wodkowski , dev@dpdk.org References: <1431429019-21130-1-git-send-email-pawelx.wodkowski@intel.com> <1431429019-21130-3-git-send-email-pawelx.wodkowski@intel.com> In-Reply-To: <1431429019-21130-3-git-send-email-pawelx.wodkowski@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] cmdline: add polling mode for command line X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 14:36:55 -0000 Hi Pawel, On 05/12/2015 01:10 PM, Pawel Wodkowski wrote: > This patch adds the ability to process console input in the same thread > as packet processing by using poll() function. > > Signed-off-by: Pawel Wodkowski > [...] > --- a/lib/librte_cmdline/cmdline.h > +++ b/lib/librte_cmdline/cmdline.h > @@ -84,6 +84,7 @@ void cmdline_printf(const struct cmdline *cl, const char *fmt, ...) > __attribute__((format(printf,2,3))); > int cmdline_in(struct cmdline *cl, const char *buf, int size); > int cmdline_write_char(struct rdline *rdl, char c); > +int cmdline_poll(struct cmdline *cl); > void cmdline_interact(struct cmdline *cl); > void cmdline_quit(struct cmdline *cl); > > diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map > index 6193462..df55def 100644 I know the rest of the file does not document the functions prototypes, but I think it could be helpful to add doxygen-style comments for new functions. > diff --git a/lib/librte_cmdline/rte_cmdline_version.map b/lib/librte_cmdline/rte_cmdline_version.map > index 6193462..df55def 100644 > --- a/lib/librte_cmdline/rte_cmdline_version.map > +++ b/lib/librte_cmdline/rte_cmdline_version.map > @@ -40,6 +40,7 @@ DPDK_2.0 { > cmdline_parse_num; > cmdline_parse_portlist; > cmdline_parse_string; > + cmdline_poll; > cmdline_printf; > cmdline_quit; > cmdline_set_prompt; > I'm not sure the .map should be modified like this, instead I would have added a new DPDK_2.1 section, like I did for this commit (reviewed by Neil): http://dpdk.org/browse/dpdk/commit/?id=bbd778248985e542175e9b4ce560f2d379e78c4e By the way, the following link is a good documentation about the .map files: http://people.freebsd.org/~deischen/symver/freebsd_versioning.txt Regards, Olivier