Re: [dpdk-dev] [PATCH v7 1/2] Simplify the ifdefs in rte.app.mk

[Olivier MATZ <olivier.matz@6wind.com>]

Hi Keith,

On 05/12/2015 01:14 AM, Keith Wiles wrote:
>      Trying to simplify the ifdefs in rte.app.mk to make the code
>      more readable and maintainable by moving LDLIBS variable to use
>      the same style as LDLIBS-y being used in the rest of the code.
>
>      Added a new variable called EXTRA_LDLIBS to be used by example apps
>      instead of using LDLIBS directly. The new internal variable _LDLIBS
>      should not be used outside of the rte.app.mk file.
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>

Sorry to comment again :)

I think it should be split differently, by topic/feature and not
by location (mk vs doc)

The first commit should only do what the title says, which is
"simplify the makefile", and not add the EXTRA_LIBS variable.

The second commit should add the EXTRA_LIBS + the associated doc.

Few nits:
- the commit log is right-shifted
- the titles could be prefixed by "mk:"
- don't forget the "--in-reply-to" :)

Regards,
Olivier