From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 54BBC5A49 for ; Tue, 12 May 2015 17:44:12 +0200 (CEST) Received: by wizk4 with SMTP id k4so159976481wiz.1 for ; Tue, 12 May 2015 08:44:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=R4KO1vjD0fx+3TvS4Y/ZEaV1dzV/yoGIpmpJBtEzgKE=; b=P56tJpbCC88GSXN+BN2CFDvoZIMqumz+uNLjKEp6d09DTFe3Ju0kiQwIp5JKCP4Fen Xy6o6WSMVqdmUt0fyaSleIifPN2H1kQhV9cOjWsLtvxWica9YK27UKUusSD6CBeCJxx4 DutbE+ac0qkiVGlOXJpZBchGrsDuoyNJ5EnAvRGl5Y3cyipQGqHBipw5F9Ab5p1NQzkU /+4xGNwHJehGIU0gXlyNDGm1hOh+cd/uO7ZbZQhodc6YGV9R59Xv/srt9etay1p9SpEG i9k3rTm5k7LJod7ohcB+C2a9So899ttirOMoBEALPcAYmkMtI1B6HAoEobfhRJhxzjvF iLUw== X-Gm-Message-State: ALoCoQkB3b5dsV6lR2fI1UHm7ISDyCyH1DRY1GmsRViPSK84Rznm2fiQyUKo6IWm63jWY2b+R66b X-Received: by 10.180.104.225 with SMTP id gh1mr30532497wib.65.1431445452142; Tue, 12 May 2015 08:44:12 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id em18sm28327111wjd.19.2015.05.12.08.44.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 08:44:11 -0700 (PDT) Message-ID: <55521FC9.2020000@6wind.com> Date: Tue, 12 May 2015 17:44:09 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Keith Wiles , dev@dpdk.org References: <017274> <1431386066-6147-1-git-send-email-keith.wiles@intel.com> In-Reply-To: <1431386066-6147-1-git-send-email-keith.wiles@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 1/2] Simplify the ifdefs in rte.app.mk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 15:44:12 -0000 Hi Keith, On 05/12/2015 01:14 AM, Keith Wiles wrote: > Trying to simplify the ifdefs in rte.app.mk to make the code > more readable and maintainable by moving LDLIBS variable to use > the same style as LDLIBS-y being used in the rest of the code. > > Added a new variable called EXTRA_LDLIBS to be used by example apps > instead of using LDLIBS directly. The new internal variable _LDLIBS > should not be used outside of the rte.app.mk file. > > Signed-off-by: Keith Wiles Sorry to comment again :) I think it should be split differently, by topic/feature and not by location (mk vs doc) The first commit should only do what the title says, which is "simplify the makefile", and not add the EXTRA_LIBS variable. The second commit should add the EXTRA_LIBS + the associated doc. Few nits: - the commit log is right-shifted - the titles could be prefixed by "mk:" - don't forget the "--in-reply-to" :) Regards, Olivier