From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pawelx.wodkowski@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id BE57E5A6B
for <dev@dpdk.org>; Tue, 12 May 2015 18:15:17 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by orsmga103.jf.intel.com with ESMTP; 12 May 2015 09:15:16 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,416,1427785200"; d="scan'208";a="727970144"
Received: from unknown (HELO [10.217.248.148]) ([10.217.248.148])
by orsmga002.jf.intel.com with ESMTP; 12 May 2015 09:15:15 -0700
Message-ID: <555226FD.2060509@intel.com>
Date: Tue, 12 May 2015 18:14:53 +0200
From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Olivier MATZ <olivier.matz@6wind.com>,
Pawel Wodkowski <pwodkowx@stargo.org>, dev@dpdk.org
References: <1431429019-21130-1-git-send-email-pawelx.wodkowski@intel.com>
<1431429019-21130-3-git-send-email-pawelx.wodkowski@intel.com>
<55521003.1080805@6wind.com>
In-Reply-To: <55521003.1080805@6wind.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] cmdline: add polling mode for command
line
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2015 16:15:18 -0000
On 2015-05-12 16:36, Olivier MATZ wrote:
> Hi Pawel,
>
> On 05/12/2015 01:10 PM, Pawel Wodkowski wrote:
>> This patch adds the ability to process console input in the same thread
>> as packet processing by using poll() function.
>>
>> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
>> [...]
>> --- a/lib/librte_cmdline/cmdline.h
>> +++ b/lib/librte_cmdline/cmdline.h
>> @@ -84,6 +84,7 @@ void cmdline_printf(const struct cmdline *cl, const
>> char *fmt, ...)
>> __attribute__((format(printf,2,3)));
>> int cmdline_in(struct cmdline *cl, const char *buf, int size);
>> int cmdline_write_char(struct rdline *rdl, char c);
>> +int cmdline_poll(struct cmdline *cl);
>> void cmdline_interact(struct cmdline *cl);
>> void cmdline_quit(struct cmdline *cl);
>>
>> diff --git a/lib/librte_cmdline/rte_cmdline_version.map
>> b/lib/librte_cmdline/rte_cmdline_version.map
>> index 6193462..df55def 100644
>
> I know the rest of the file does not document the functions
> prototypes, but I think it could be helpful to add doxygen-style
> comments for new functions.
Yes, no problem.
>
>> diff --git a/lib/librte_cmdline/rte_cmdline_version.map
>> b/lib/librte_cmdline/rte_cmdline_version.map
>> index 6193462..df55def 100644
>> --- a/lib/librte_cmdline/rte_cmdline_version.map
>> +++ b/lib/librte_cmdline/rte_cmdline_version.map
>> @@ -40,6 +40,7 @@ DPDK_2.0 {
>> cmdline_parse_num;
>> cmdline_parse_portlist;
>> cmdline_parse_string;
>> + cmdline_poll;
>> cmdline_printf;
>> cmdline_quit;
>> cmdline_set_prompt;
>>
>
> I'm not sure the .map should be modified like this, instead I
> would have added a new DPDK_2.1 section, like I did for this
> commit (reviewed by Neil):
> http://dpdk.org/browse/dpdk/commit/?id=bbd778248985e542175e9b4ce560f2d379e78c4e
>
>
> By the way, the following link is a good documentation about the
> .map files:
> http://people.freebsd.org/~deischen/symver/freebsd_versioning.txt
Thank you, I will follow those instructions :)
Please check v2 I will send shortly.
--
Pawel