From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id CD9655694 for ; Wed, 13 May 2015 15:56:27 +0200 (CEST) Received: by wgbhc8 with SMTP id hc8so10921762wgb.3 for ; Wed, 13 May 2015 06:56:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=FLzefRwRP/FbkZ4/17N49zu6ZTSuinlJa9LYAOLedVw=; b=Y3DKCQNzF2+kG/E15lReqhakbnm6kXkJG9kHyLU7+UtRockDwyjUCnixZPv338+gNo AcfnNY+mjkI2FJM+BA/TS8roi+5w/EwK+6vWYuT/2emDigsKWZh5L3Kucw/qtgJV8TUJ tfHgy3UeKzAkZ3OxrOEqgrdOzp3KEXBO0eHgA4vhVaBpavf8fmZjVDwZypUOWEJe02ou qA2LLyY0/3tjtXFTa1ZkJD32EBuP7WvrCEnSmx8dqhVBou3TOtiSt52y+n4qtzkzW/Bp LdE2Z96M9vw4YXg7Tcl4prYDWpS5iqitXtZaFKCjqTmUoRSQhBrMlQnumNgtUe48AonG zOzg== X-Gm-Message-State: ALoCoQmYBnwUr0YqVnrllzdCfQty9RQam2dl9PnmKuUP4kBaz3cn7jCvBKfoF1VSrOH2NzSHxBEn X-Received: by 10.180.93.7 with SMTP id cq7mr15068244wib.24.1431525387723; Wed, 13 May 2015 06:56:27 -0700 (PDT) Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id fo7sm8234678wic.1.2015.05.13.06.56.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 May 2015 06:56:26 -0700 (PDT) Message-ID: <55535807.5070900@6wind.com> Date: Wed, 13 May 2015 15:56:23 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: "Wiles, Keith" , "dev@dpdk.org" References: <1431386066-6147-1-git-send-email-keith.wiles@intel.com> <1431457872-10345-1-git-send-email-keith.wiles@intel.com> <5553000D.3030004@6wind.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 1/2] mk:Simplify the ifdefs in rte.app.mk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 13:56:28 -0000 Hi Keith, On 05/13/2015 03:17 PM, Wiles, Keith wrote: >>> >>> endif # ifeq ($(NO_AUTOLIBS),) >>> >>> -LDLIBS += $(CPU_LDLIBS) >>> +LDLIBS += $(_LDLIBS-y) $(EXTRA_LDLIBS) >>> >> >> As discussed in the previous mail, all things that are about >> EXTRA_LDLIBS should be moved in the second patch. Therefore, >> the title of the second patch should not be "update doc...", but >> something like "mk: introduce EXTRA_LDLIBS...". >> >> By the way, I missed that before, but it seems that your >> patch removes CPU_LDLIBS, I don't think it's correct. > > I found no reference to CPU_LDLIBS in the docs or code other then then one > line. We now have EXTRA_LDLIBS for the command line, right? Yes, but your patch says "simplify the ifdef". Removing a variable (even if it is not used) in this patch is not a good idea. Now, the CPU_CFLAGS, CPU_LDFLAGS, CPU_LDLIBS can be defined internally by the rte.vars.mk in mk/arch/ or mk/machine/ directories. Regards, Olivier