From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A2F3DA00C3;
	Mon,  3 Oct 2022 16:02:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 955B5410D2;
	Mon,  3 Oct 2022 16:02:41 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 784AC40695
 for <dev@dpdk.org>; Mon,  3 Oct 2022 16:02:39 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 1BD6266;
 Mon,  3 Oct 2022 17:02:39 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 1BD6266
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664805759;
 bh=NUDPgcd2RiGU38W8TMvF3Hkukk+YfgfTXWn4tl7HN6I=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=GMUI4gEiiDJqOutcWsacGwcQ21rFjOpPz7xjVBOFkjRAMmGzuCg3PO95E7gbFYKDC
 jkCMWjs4I/Y4iVUT/ScAuQmD/xohHx7TaD4r4jwIhokSErFiv4sHpSdAhPxqugWi8u
 CKRYYOUHvR9Um3pT63jdkKyt3sKJO37H0ljjYE1w=
Message-ID: <5555f33f-8403-eb8a-3cc0-12a655c9fb8c@oktetlabs.ru>
Date: Mon, 3 Oct 2022 17:02:38 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 08/14] net/idpf: add support for basic Rx/Tx datapath
Content-Language: en-US
To: Junfeng Guo <junfeng.guo@intel.com>, qi.z.zhang@intel.com,
 jingjing.wu@intel.com, beilei.xing@intel.com
Cc: dev@dpdk.org, xiao.w.wang@intel.com, Xiaoyun Li <xiaoyun.li@intel.com>
References: <20220803113104.1184059-1-junfeng.guo@intel.com>
 <20220905105828.3190335-1-junfeng.guo@intel.com>
 <20220905105828.3190335-9-junfeng.guo@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220905105828.3190335-9-junfeng.guo@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/5/22 13:58, Junfeng Guo wrote:
> Add basic RX & TX support in split queue mode and single queue mode.

RX -> Rx, TX -> Tx

> Split queue mode is selected by default.

What is split queue mode? Where is it defined/described?

The patch is very big again. Please, start from really basic Rx
and Tx functionality and then add offloads one by one.
Otherwise it is really hard to review everything at once.