DPDK patches and discussions
 help / color / mirror / Atom feed
From: Declan Doherty <declan.doherty@intel.com>
To: Andriy Berestovskyy <aber@semihalf.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] bond: mode 4 promiscuous mode
Date: Wed, 20 May 2015 13:34:20 +0100	[thread overview]
Message-ID: <555C7F4C.8050208@intel.com> (raw)
In-Reply-To: <CAOysbxr30TQ+a7BDHSjd29=3W-Z7V9bYbxcSeyCMZYOLjH=-Ag@mail.gmail.com>

On 15/05/15 14:36, Andriy Berestovskyy wrote:
> Hey guys,
> Can we in function bond_mode_8023ad_activate_slave() try to add to the
> slave bond and LACP multicast MACs first? And then we would fall back
> into promiscuous mode if the adding has failed.
>
> In other words:
>
> if (rte_eth_dev_mac_addr_add(slave_id, bond_mac) != 0
>      || rte_eth_dev_mac_addr_add(slave_id, lacp_mac) != 0) {
>      ...
>      rte_eth_promiscuous_enable(slave_id)
> }
>
> Seems to work fine on my setup, but I might miss something.
>
> Regards,
> Andriy
>

Hey Andriy,

that sounds like a sensible idea, if you want to submit your changes in 
a patch or rfc that would be great, I'll have a look and will get them 
tested by our validation team.

Thanks
Declan

      reply	other threads:[~2015-05-20 12:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-15 13:36 Andriy Berestovskyy
2015-05-20 12:34 ` Declan Doherty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555C7F4C.8050208@intel.com \
    --to=declan.doherty@intel.com \
    --cc=aber@semihalf.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).