DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] bond: mode 4 promiscuous mode
@ 2015-05-15 13:36 Andriy Berestovskyy
  2015-05-20 12:34 ` Declan Doherty
  0 siblings, 1 reply; 2+ messages in thread
From: Andriy Berestovskyy @ 2015-05-15 13:36 UTC (permalink / raw)
  To: dev

Hey guys,
Can we in function bond_mode_8023ad_activate_slave() try to add to the
slave bond and LACP multicast MACs first? And then we would fall back
into promiscuous mode if the adding has failed.

In other words:

if (rte_eth_dev_mac_addr_add(slave_id, bond_mac) != 0
    || rte_eth_dev_mac_addr_add(slave_id, lacp_mac) != 0) {
    ...
    rte_eth_promiscuous_enable(slave_id)
}

Seems to work fine on my setup, but I might miss something.

Regards,
Andriy

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] bond: mode 4 promiscuous mode
  2015-05-15 13:36 [dpdk-dev] bond: mode 4 promiscuous mode Andriy Berestovskyy
@ 2015-05-20 12:34 ` Declan Doherty
  0 siblings, 0 replies; 2+ messages in thread
From: Declan Doherty @ 2015-05-20 12:34 UTC (permalink / raw)
  To: Andriy Berestovskyy, dev

On 15/05/15 14:36, Andriy Berestovskyy wrote:
> Hey guys,
> Can we in function bond_mode_8023ad_activate_slave() try to add to the
> slave bond and LACP multicast MACs first? And then we would fall back
> into promiscuous mode if the adding has failed.
>
> In other words:
>
> if (rte_eth_dev_mac_addr_add(slave_id, bond_mac) != 0
>      || rte_eth_dev_mac_addr_add(slave_id, lacp_mac) != 0) {
>      ...
>      rte_eth_promiscuous_enable(slave_id)
> }
>
> Seems to work fine on my setup, but I might miss something.
>
> Regards,
> Andriy
>

Hey Andriy,

that sounds like a sensible idea, if you want to submit your changes in 
a patch or rfc that would be great, I'll have a look and will get them 
tested by our validation team.

Thanks
Declan

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-20 12:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 13:36 [dpdk-dev] bond: mode 4 promiscuous mode Andriy Berestovskyy
2015-05-20 12:34 ` Declan Doherty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).