From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 10462234 for ; Fri, 22 May 2015 14:51:02 +0200 (CEST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 29E983674BC; Fri, 22 May 2015 12:51:01 +0000 (UTC) Received: from tfherb.local (vpn-59-98.rdu2.redhat.com [10.10.59.98]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4MCp0pW003546; Fri, 22 May 2015 08:51:00 -0400 Message-ID: <555F2634.3040307@redhat.com> Date: Fri, 22 May 2015 08:51:00 -0400 From: Thomas F Herbert Organization: Red Hat User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Ouyang, Changchun" , "dpdk >> dev@dpdk.org" References: <1432194581-15301-1-git-send-email-changchun.ouyang@intel.com> <1432194581-15301-5-git-send-email-changchun.ouyang@intel.com> <555E88B5.7080906@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Subject: Re: [dpdk-dev] [PATCH 4/6] vhost: Add new command line option: rxq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2015 12:51:02 -0000 On 5/22/15 2:05 AM, Ouyang, Changchun wrote: > Hi Thomas, > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas F Herbert >> Sent: Friday, May 22, 2015 9:39 AM >> To: dpdk >> dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 4/6] vhost: Add new command line option: >> rxq >> >> >> >> On 5/21/15 3:49 AM, Ouyang Changchun wrote: >>> Sample vhost need know the queue number user want to enable for each >>> virtio device, so add the new option '--rxq' into it. >> Could you also add the new --rxq option description to us_vhost_usage()? > > Actually we have, please see below True enough. However, the code calls rte_eal_init() before parsing args and therefore takes rte_exit before printing usage of the non-eal options. > >> +585,8 @@ >>> us_vhost_usage(const char *prgname) >>> " --rx-desc-num [0-N]: the number of descriptors on rx, >> " >>> "used only when zero copy is enabled.\n" >>> " --tx-desc-num [0-N]: the number of descriptors on tx, >> " >>> - "used only when zero copy is enabled.\n", >>> + "used only when zero copy is enabled.\n" >>> + " --rxq [1,2,4]: rx queue number for each vhost >> device\n", >>> prgname); >>> } > > Thanks > Changchun >