From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B129441C23; Mon, 6 Feb 2023 16:22:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5001442B7E; Mon, 6 Feb 2023 16:22:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7DE66427E9 for ; Mon, 6 Feb 2023 16:22:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675696936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=72EXvijMhTWlDoV7QI2eke94Yuq0gJQrUNdIJ3bm9Fk=; b=cwUuD2Iexfhrck5rs6w/HA64k5FKt7XqGYvoyeBdJWX99Z+pfu3W9qpbuVyt85yZWvdVSj iKDHumxSo4mfy56vOZrWxg4H8mL9bfHtluqNq6O2LHEGF8aNazkukCvAF5dBU/O3Sy8+oK oix1Kk7vTK0h25Jz7F0PUhQSnKjBJMk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-789opIyBOvW4e0WplP-PjA-1; Mon, 06 Feb 2023 10:22:09 -0500 X-MC-Unique: 789opIyBOvW4e0WplP-PjA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B64F43C0F18D; Mon, 6 Feb 2023 15:22:07 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1870B40CF8E2; Mon, 6 Feb 2023 15:22:03 +0000 (UTC) Message-ID: <55627722-b8b9-f2e6-7264-53a15275751b@redhat.com> Date: Mon, 6 Feb 2023 16:22:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com References: <20230120205553.62419-1-hernan.vargas@intel.com> <20230120205553.62419-2-hernan.vargas@intel.com> From: Maxime Coquelin Subject: Re: [PATCH v1 1/1] baseband/acc: fix check after deref and dead code In-Reply-To: <20230120205553.62419-2-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/20/23 21:55, Hernan Vargas wrote: > Fix potential issue of dereferencing a pointer before null check. > Remove null check for value that could never be null. > > Coverity issue: 381646, 381631 > Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Please Cc stable, since it fixes a patch merged in v22.11. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 0992cb5d1e..a600511f4b 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,12 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > - if (q == NULL) > - return 0; > -#ifdef RTE_LIBRTE_BBDEV_DEBUG > - if (unlikely(ops == 0)) > + if (avail == 0) Introduction of this new check on avail is not explained in the commit message, it does not seem related to the purpose of this patch. It looks like an optimization, so should be in a separate patch. > return 0; > -#endif > + > op = acc_op_tail(q, 0); > if (unlikely(ops == NULL || op == NULL)) > return 0;