From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id 50902B6AB for ; Mon, 25 May 2015 18:32:51 +0200 (CEST) Received: from [192.168.1.102] (x5ce220c8.dyn.telefonica.de [92.226.32.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.bisdn.de (Postfix) with ESMTPSA id 01E5BA3378 for ; Mon, 25 May 2015 18:32:50 +0200 (CEST) Message-ID: <55634EB1.1090408@bisdn.de> Date: Mon, 25 May 2015 18:32:49 +0200 From: Marc Sune User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: "dev@dpdk.org" References: <1431387946-29950-1-git-send-email-marc.sune@bisdn.de> In-Reply-To: <1431387946-29950-1-git-send-email-marc.sune@bisdn.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 0/2] ethdev: add port speed capability bitmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 16:32:51 -0000 Any objections to this one? Otherwise I will rebase and propose a formal patch marc On 12/05/15 01:45, Marc Sune wrote: > The current rte_eth_dev_info abstraction does not provide any mechanism to > know the supported speed(s) of an ethdev. > > For some drivers (e.g. ixgbe), an educated guess can be done based on the > driver's name (driver_name in rte_eth_dev_info), see: > > http://dpdk.org/ml/archives/dev/2013-August/000412.html > > However, i) doing string comparisons is annoying, and can silently > break existing applications if PMDs change their names ii) it does not > provide all the supported capabilities of the ethdev iii) for some drivers it > is impossible determine correctly the (max) speed by the application > (e.g. in i40, distinguish between XL710 and X710). > > This small patch adds speed_capa bitmap in rte_eth_dev_info, which is filled > by the PMDs according to the physical device capabilities. > > WARNING: the patch is only tested with e1000s, and should be reviewed for > accuracy. > > > Marc Sune (2): > Added ETH_SPEED_CAP bitmap in rte_eth_dev_info > Filling speed capability bitmaps in the PMDs > > lib/librte_ether/rte_ethdev.h | 24 ++++++++++++++++++++++++ > lib/librte_pmd_e1000/em_ethdev.c | 6 ++++++ > lib/librte_pmd_e1000/igb_ethdev.c | 6 ++++++ > lib/librte_pmd_fm10k/fm10k_ethdev.c | 3 +++ > lib/librte_pmd_i40e/i40e_ethdev.c | 9 +++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 10 ++++++++++ > lib/librte_pmd_mlx4/mlx4.c | 6 ++++++ > 7 files changed, 64 insertions(+) >