From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id 8FA2B1396 for ; Tue, 26 May 2015 10:41:45 +0200 (CEST) Received: from [172.16.250.156] (unknown [172.16.250.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.bisdn.de (Postfix) with ESMTPSA id 402E3A23F3; Tue, 26 May 2015 10:41:45 +0200 (CEST) Message-ID: <556431C8.6050404@bisdn.de> Date: Tue, 26 May 2015 10:41:44 +0200 From: Marc Sune User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1431387946-29950-1-git-send-email-marc.sune@bisdn.de> <1431387946-29950-2-git-send-email-marc.sune@bisdn.de> <20150525104649.06f1916c@urahara> In-Reply-To: <20150525104649.06f1916c@urahara> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2015 08:41:45 -0000 On 25/05/15 19:46, Stephen Hemminger wrote: > On Tue, 12 May 2015 01:45:45 +0200 > Marc Sune wrote: > >> +/** >> + * Ethernet device information >> + */ >> struct rte_eth_dev_info { >> struct rte_pci_device *pci_dev; /**< Device PCI information. */ >> const char *driver_name; /**< Device Driver name. */ >> @@ -924,6 +947,7 @@ struct rte_eth_dev_info { >> uint16_t vmdq_queue_base; /**< First queue ID for VMDQ pools. */ >> uint16_t vmdq_queue_num; /**< Queue number for VMDQ pools. */ >> uint16_t vmdq_pool_base; /**< First ID of VMDQ pools. */ >> + uint16_t speed_capa; /**< Supported speeds bitmap. */ > Since you are likely to run out of 16 bits in future, why not 32 bits now? Indeed, why not. I will convert it to uint32_t when I send the new version. Thanks marc