From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge
Date: Wed, 27 May 2015 10:09:08 +0200 [thread overview]
Message-ID: <55657BA4.5060305@netinsight.net> (raw)
In-Reply-To: <CALwxeUtOW7o5PCpG0vXhp9JqOppw+71aEtnFXud2U1HaXnKKpQ@mail.gmail.com>
Hi John and David!
On 2015-05-27 09:29, Mcnamara, John wrote:>
> Minor comments.
>
> * Without mem_parsed the () aren't required and the conditional will
fit on one line.
>
> * The section prefix on the first/subject line should be "eal:" and
the commit message/justification could be clearer. It would be worth
doing a "git log" on the file and following the previous conventions for
commit message on that component/file.
OK, I'll fix these issues.
On 2015-05-27 09:43, David Marchand wrote:
> Well, I asked some question last time :
> http://dpdk.org/ml/archives/dev/2015-March/015867.html
>
> This patch looks good but since I don't use this --no-huge that often, I
> would like to know how you tested this.
I used the pcap PMD driver with file input, basically
./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev
'eth_pcap0,rx_pcap=/tmp/eth-out.pcap,tx_pcap=/tmp/eth0.pcap'
this patch allows me to run this as myself (i.e., not root)
> And please, when resending a patch, it should be marked as vX.
Sorry about that, I stashed it and forgot about it for a while, and then
just re-made the commit. (Not only that: I lost the reply in the flood
of DPDK mails, so sort of what I was complaining about in the first place!)
Anyway, I'll update the patch and resend.
// Simon
prev parent reply other threads:[~2015-05-27 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 12:24 Simon Kagstrom
2015-05-27 7:29 ` Mcnamara, John
2015-05-27 7:43 ` David Marchand
2015-05-27 8:09 ` Simon Kågström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55657BA4.5060305@netinsight.net \
--to=simon.kagstrom@netinsight.net \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).