From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 390FB567E for ; Wed, 27 May 2015 15:06:50 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4RD6lkn029376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 May 2015 09:06:47 -0400 Received: from tfherb-2.local (vpn-62-242.rdu2.redhat.com [10.10.62.242]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4RD6k9N028867; Wed, 27 May 2015 09:06:46 -0400 Message-ID: <5565C166.4090505@redhat.com> Date: Wed, 27 May 2015 09:06:46 -0400 From: Thomas F Herbert Organization: Red Hat User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Simon Kagstrom , dev@dpdk.org, david.marchand@6wind.com, john.mcnamara@intel.com References: <20150527113016.2c31ba7e@miho> In-Reply-To: <20150527113016.2c31ba7e@miho> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Subject: Re: [dpdk-dev] [PATCH v2] eal: Allow combining -m and --no-huge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 13:06:50 -0000 On 5/27/15 5:30 AM, Simon Kagstrom wrote: > Needed to run as non-root but with higher memory allocations, and > removes a constraint on no-huge mode being limited to 64M. A usage > example is if running with file input with the pcap PMD, which can be > done as non-root after this patch via e.g., Simon, I just tried applying v2 of the patch to master: git apply ../patches/eal_common_options.patch error: patch failed: lib/librte_eal/common/eal_common_options.c:850 error: lib/librte_eal/common/eal_common_options.c: patch does not apply > > ./test-dpdk --no-huge -m 1024 -l 0,1 -n3 --vdev 'eth_pcap0,rx_pcap=/tmp/eth-rx.pcap,tx_pcap=/tmp/eth-tx.pcap' > > Signed-off-by: Simon Kagstrom > Signed-off-by: Johan Faltstrom > --- > v2: > * Remove unneeded parentheses and merge lines > > * Patch prefix now eal: > > * Add example and more description (from David Marchand) > > lib/librte_eal/common/eal_common_options.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 8fcb1ab..1f459ac 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -850,9 +850,8 @@ eal_check_common_options(struct internal_config *internal_cfg) > "be specified at the same time\n"); > return -1; > } > - if (internal_cfg->no_hugetlbfs && > - (mem_parsed || internal_cfg->force_sockets == 1)) { > - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot " > + if (internal_cfg->no_hugetlbfs && internal_cfg->force_sockets == 1) { > + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot " > "be specified together with --"OPT_NO_HUGE"\n"); > return -1; > } >