From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id 9B059CE7 for ; Wed, 27 May 2015 15:52:37 +0200 (CEST) Received: from [172.16.250.156] (unknown [172.16.250.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx.bisdn.de (Postfix) with ESMTPSA id 6B962A3378 for ; Wed, 27 May 2015 15:52:36 +0200 (CEST) Message-ID: <5565CC22.8050003@bisdn.de> Date: Wed, 27 May 2015 15:52:34 +0200 From: Marc Sune User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1432734469-1668-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1432734469-1668-1-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/4] kni: add function to query the name of a kni object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 13:52:37 -0000 On 27/05/15 15:47, Bruce Richardson wrote: > When a KNI object is created, a name is assigned to it which is stored > internally. There is also an API function to look up a KNI object by > name, but there is no API to query the current name of an existing > KNI object. This patch adds just such an API. > > Signed-off-by: Bruce Richardson > --- > lib/librte_kni/rte_kni.c | 6 ++++++ > lib/librte_kni/rte_kni.h | 10 ++++++++++ > lib/librte_kni/rte_kni_version.map | 1 + > 3 files changed, 17 insertions(+) > > diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c > index 4e70fa0..c5a0089 100644 > --- a/lib/librte_kni/rte_kni.c > +++ b/lib/librte_kni/rte_kni.c > @@ -674,6 +674,12 @@ rte_kni_get(const char *name) > return NULL; > } > > +const char * > +rte_kni_get_name(const struct rte_kni *kni) > +{ > + return kni->name; > +} Since a pointer to the kni context (struct rte_kni) is exposed to the user (rte_kni_get() and rte_kni_alloc ()), and the field is directly in the struct, is this API call really necessary? I would only see this necessary if the API would only expose a handle, like a port_id for ethdev Marc > + > /* > * It is deprecated and just for backward compatibility. > */ > diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h > index 44240fe..0c74251 100644 > --- a/lib/librte_kni/rte_kni.h > +++ b/lib/librte_kni/rte_kni.h > @@ -248,6 +248,16 @@ extern uint8_t rte_kni_get_port_id(struct rte_kni *kni) \ > extern struct rte_kni *rte_kni_get(const char *name); > > /** > + * Get the name given to a KNI device > + * > + * @param kni > + * The KNI instance to query > + * @return > + * The pointer to the KNI name > + */ > +extern const char *rte_kni_get_name(const struct rte_kni *kni); > + > +/** > * Get the KNI context of the specific port. > * > * Note: It is deprecated and just for backward compatibility. > diff --git a/lib/librte_kni/rte_kni_version.map b/lib/librte_kni/rte_kni_version.map > index b0bbf4d..e5e4e1b 100644 > --- a/lib/librte_kni/rte_kni_version.map > +++ b/lib/librte_kni/rte_kni_version.map > @@ -6,6 +6,7 @@ DPDK_2.0 { > rte_kni_create; > rte_kni_get; > rte_kni_get_port_id; > + rte_kni_get_name; > rte_kni_handle_request; > rte_kni_info_get; > rte_kni_init;