From: Marc Sune <marc.sune@bisdn.de>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] kni: add missing include dependencies
Date: Thu, 28 May 2015 10:54:55 +0200 [thread overview]
Message-ID: <5566D7DF.4040707@bisdn.de> (raw)
In-Reply-To: <1432556634-9498-3-git-send-email-bruce.richardson@intel.com>
On 25/05/15 14:23, Bruce Richardson wrote:
> The file rte_kni.h depends upon a number of other headers, some of which
> are missing from the #include lines. The following #includes are added:
> * rte_memory.h - for the definition of phys_addr_t
> * rte_mempool.h - for the definition of mempool struct and the mempool
> create function.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_kni/rte_kni.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h
> index 98edd72..44240fe 100644
> --- a/lib/librte_kni/rte_kni.h
> +++ b/lib/librte_kni/rte_kni.h
> @@ -47,6 +47,8 @@
> */
>
> #include <rte_pci.h>
> +#include <rte_memory.h>
> +#include <rte_mempool.h>
>
> #include <exec-env/rte_kni_common.h>
>
A fwd declaration of struct rte_mempool would be sufficient, but
Acked-by: Marc Sune <marc.sune@bisdn.de>
next prev parent reply other threads:[~2015-05-28 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 12:23 [dpdk-dev] [PATCH 0/2] Add missing includes to headers Bruce Richardson
2015-05-25 12:23 ` [dpdk-dev] [PATCH 1/2] eal: add missing include <stdio.h> to rte_pci.h Bruce Richardson
2015-05-28 8:52 ` Marc Sune
2015-05-25 12:23 ` [dpdk-dev] [PATCH 2/2] kni: add missing include dependencies Bruce Richardson
2015-05-28 8:54 ` Marc Sune [this message]
2015-05-29 17:36 ` [dpdk-dev] [PATCH 0/2] Add missing includes to headers Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566D7DF.4040707@bisdn.de \
--to=marc.sune@bisdn.de \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).