From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.kagstrom@netinsight.net>
Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21])
 by dpdk.org (Postfix) with SMTP id 5B58611C5
 for <dev@dpdk.org>; Thu, 28 May 2015 12:37:28 +0200 (CEST)
Received: from [10.100.1.152] (unverified [10.100.1.152]) by
 ernst.netinsight.se
 (EMWAC SMTPRS 0.83) with SMTP id <B0030037430@ernst.netinsight.se>;
 Thu, 28 May 2015 12:37:17 +0200
Message-ID: <5566EFDD.5040209@netinsight.net>
Date: Thu, 28 May 2015 12:37:17 +0200
From: =?windows-1252?Q?Simon_K=E5gstr=F6m?=
 <simon.kagstrom@netinsight.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>, 
 "Zhang, Helin" <helin.zhang@intel.com>,
 Alexander Guy <alexander@andern.org>, 
 Julien Cretin <julien.cretin@trust-in-soft.com>,
 "Buriez, Patrice" <patrice.buriez@intel.com>
References: <20150527134524.5f107cac@miho>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86CAC4@SHSMSX104.ccr.corp.intel.com>
 <F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com>
In-Reply-To: <F6F2A6264E145F47A18AB6DF8E87425D1358F48E@IRSMSX102.ger.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu
	kernel version
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2015 10:37:28 -0000

On 2015-05-28 12:05, Wodkowski, PawelX wrote:
>>>
>>> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
>>> -                        cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comma))
>>> +UBUNTU_KERNEL_CODE := $(shell echo `grep UTS_RELEASE
>>> $(RTE_KERNELDIR)/include/generated/utsrelease.h \
>>> +	 | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1)
> 
> It is fine for me if it do the job and does not break build on other OS (also other 
> Ubuntu versions especially 12.04 if we still support it).
> Please only check if UTS_RELEASE is available on all Ubuntu versions DPDK support.

>>From some digging, it appears it entered the kernel tree in 2006 and
moved to include/generated/ in 2009 so I guess that should be fine for
DPDK builds?

// Simon