From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 296A75693 for ; Mon, 1 Jun 2015 10:50:01 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YzLUR-0005VF-8g; Mon, 01 Jun 2015 10:54:39 +0200 Message-ID: <556C1CD4.7030604@6wind.com> Date: Mon, 01 Jun 2015 10:50:28 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Helin Zhang , dev@dpdk.org References: <1430793143-3610-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-1-git-send-email-helin.zhang@intel.com> <1432629400-25303-2-git-send-email-helin.zhang@intel.com> In-Reply-To: <1432629400-25303-2-git-send-email-helin.zhang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/5] ixgbe: remove a discarded source line X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2015 08:50:01 -0000 Hi Helin, On 05/26/2015 10:36 AM, Helin Zhang wrote: > Little endian to CPU order conversion had been added for reading > vlan tag from RX descriptor, while its original source line was > forgotten to delete. That's a discarded source line and should be > deleted. > > Signed-off-by: Helin Zhang > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index 4f9ab22..041c544 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -981,7 +981,6 @@ ixgbe_rx_scan_hw_ring(struct ixgbe_rx_queue *rxq) > pkt_len = (uint16_t)(rxdp[j].wb.upper.length - rxq->crc_len); > mb->data_len = pkt_len; > mb->pkt_len = pkt_len; > - mb->vlan_tci = rxdp[j].wb.upper.vlan; > mb->vlan_tci = rte_le_to_cpu_16(rxdp[j].wb.upper.vlan); > > /* convert descriptor fields to rte mbuf flags */ > Maybe the following should be added in the commit log: Fixes: 23fcffe8ffac ("ixgbe: fix id and hash with flow director") Acked-by: Olivier Matz