From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups
Date: Tue, 02 Jun 2015 07:43:30 +0200 [thread overview]
Message-ID: <556D4282.6040309@netinsight.net> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A86E643@SHSMSX104.ccr.corp.intel.com>
On 2015-06-02 05:44, Zhang, Helin wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom
>> Sent: Thursday, May 7, 2015 9:18 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle
>> multicast groups
>>
>> This is needed to add / remove interfaces in multicast groups via the ip tool.
> Could you help to explain with more details of why it is needed?
We did some (very basic) tests with IGMP, which involves adding
multicast addresses to ETH interfaces. This is done via the ip tool, an
example can be found on e.g.,
http://superuser.com/questions/324824/linux-built-in-or-open-source-program-to-join-multicast-group
and this will fail on KNI interfaces with the current code because of an
unimplemented ioctl (as Stephen Hemminger said earlier). The patch
simply adds an empty callback so that the ioctl succeeds, and this is
the same thing as the Linux tap interface does (so I think it should be
enough for KNI as well).
If you want, I can update the patch with a bit more description
(something like the above).
// Simon
next prev parent reply other threads:[~2015-06-02 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 13:17 Simon Kagstrom
2015-05-20 6:04 ` Simon Kågström
2015-05-28 9:11 ` Simon Kågström
2015-05-28 14:56 ` Stephen Hemminger
2015-06-02 3:44 ` Zhang, Helin
2015-06-02 5:43 ` Simon Kågström [this message]
2015-06-02 5:48 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D4282.6040309@netinsight.net \
--to=simon.kagstrom@netinsight.net \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).