From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 95FF9BDC2 for ; Tue, 2 Jun 2015 07:43:35 +0200 (CEST) Received: from [10.100.1.152] (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id ; Tue, 02 Jun 2015 07:43:30 +0200 Message-ID: <556D4282.6040309@netinsight.net> Date: Tue, 02 Jun 2015 07:43:30 +0200 From: =?windows-1252?Q?Simon_K=E5gstr=F6m?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Zhang, Helin" , "dev@dpdk.org" References: <20150507151754.1620c4cb@miho> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle multicast groups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 05:43:35 -0000 On 2015-06-02 05:44, Zhang, Helin wrote: >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom >> Sent: Thursday, May 7, 2015 9:18 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH / RFC] kni: Add set_rx_mode callback to handle >> multicast groups >> >> This is needed to add / remove interfaces in multicast groups via the ip tool. > Could you help to explain with more details of why it is needed? We did some (very basic) tests with IGMP, which involves adding multicast addresses to ETH interfaces. This is done via the ip tool, an example can be found on e.g., http://superuser.com/questions/324824/linux-built-in-or-open-source-program-to-join-multicast-group and this will fail on KNI interfaces with the current code because of an unimplemented ioctl (as Stephen Hemminger said earlier). The patch simply adds an empty callback so that the ioctl succeeds, and this is the same thing as the Linux tap interface does (so I think it should be enough for KNI as well). If you want, I can update the patch with a bit more description (something like the above). // Simon