From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cunming.liang@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 062405A35
 for <dev@dpdk.org>; Wed,  3 Jun 2015 09:17:25 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 03 Jun 2015 00:17:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,545,1427785200"; d="scan'208";a="501972738"
Received: from shwdeisgchi017.ccr.corp.intel.com (HELO [10.239.66.47])
 ([10.239.66.47])
 by FMSMGA003.fm.intel.com with ESMTP; 03 Jun 2015 00:17:24 -0700
Message-ID: <556EAA04.6030601@intel.com>
Date: Wed, 03 Jun 2015 15:17:24 +0800
From: "Liang, Cunming" <cunming.liang@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Stephen Hemminger <shemming@brocade.com>
References: <1432889125-20255-1-git-send-email-cunming.liang@intel.com>	<1433228006-24661-1-git-send-email-cunming.liang@intel.com>	<1433228006-24661-7-git-send-email-cunming.liang@intel.com>
 <20150602092753.7c42eff9@urahara>
In-Reply-To: <20150602092753.7c42eff9@urahara>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, liang-min.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH v10 06/13] eal/linux: standalone intr event
 fd create support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2015 07:17:26 -0000



On 6/3/2015 12:27 AM, Stephen Hemminger wrote:
> Minor spelling and stuff. I am a terrible speller...
>
>> The patch exposes intr event fd create and release for PMD.
>> The device driver can assign the number of event associated with interrupt vector.
>> It also provides misc funtions to check 1) allows other slowpath intr(e.g. lsc);
>   'funtions' may be misspelled - perhaps 'functions'?
>    
>
>> +/**
>> + * It enables the fastpath event fds if it's necessary.
>> + * It creates event fds when multi-vectors allowed,
>> + * otherwise it multiplexes the single event fds.
>> + *
>> + * @param intr_handle
>> + *   Pointer to the interrupt handle.
>> + * @param nb_vec
>> + *   Number of intrrupt vector trying to enable.
>   'intrrupt' may be misspelled - perhaps 'interrupt'?
Thanks Stephen, will send the cleanup patch.