From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Xiao Wang <xiao.w.wang@intel.com>, tiwei.bie@intel.com
Cc: dev@dpdk.org, xiaolong.ye@intel.com, zhihong.wang@intel.com,
Chao Zhu <chaozhu@linux.vnet.ibm.com>,
Thomas Monjalon <thomas@monjalon.net>,
Qian Xu <qian.q.xu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration support
Date: Tue, 2 Oct 2018 15:45:57 +0100 [thread overview]
Message-ID: <556b4896-d311-a4ae-37e2-eacda2be5994@intel.com> (raw)
In-Reply-To: <3f10edab-be6d-9e48-d022-e569ae79adc7@intel.com>
On 9/21/2018 12:55 AM, Ferruh Yigit wrote:
> On 9/10/2018 12:01 PM, Xiao Wang wrote:
>> IFCVF can help to log dirty page in live migration stage,
>> each queue's index can be read and configured to support
>> VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE.
>>
>> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>
> <...>
>
>> +static void
>> +ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf)
>> +{
>> + uint32_t i, size;
>> + uint64_t pfn;
>> +
>> + pfn = hw->vring[queue].used / PAGE_SIZE;
>> + size = hw->vring[queue].size * sizeof(struct vring_used_elem) +
>> + sizeof(__virtio16) * 3;
>
> Getting a build error for PowerPC [1], can someone from PPC side confirm it please?
>
> [1]
> .../drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_used_ring_log’:
> .../drivers/net/ifc/ifcvf_vdpa.c:288:11: error: ‘__virtio16’ undeclared (first
> use in this function)
> sizeof(__virtio16) * 3;
> ^~~~~~~~~~
Also "__virtio16" seems added into Linux kernel on v3.19. Systems with kernel
version less than this causing build error.
Can we replace "__virtio16" usage with basic types to prevent build error?
If so can you please send this as a fix patch?
Thanks,
ferruh
next prev parent reply other threads:[~2018-10-02 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 11:01 Xiao Wang
2018-09-13 20:39 ` Ye Xiaolong
2018-09-19 14:36 ` Zhang, Qi Z
2018-09-20 23:55 ` Ferruh Yigit
2018-10-02 14:45 ` Ferruh Yigit [this message]
2018-10-08 2:59 ` Wang, Xiao W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556b4896-d311-a4ae-37e2-eacda2be5994@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=qian.q.xu@intel.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).