From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D5F084F90 for ; Tue, 2 Oct 2018 16:46:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 07:46:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="267820757" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 07:45:58 -0700 From: Ferruh Yigit To: Xiao Wang , tiwei.bie@intel.com Cc: dev@dpdk.org, xiaolong.ye@intel.com, zhihong.wang@intel.com, Chao Zhu , Thomas Monjalon , Qian Xu References: <20180910110123.138273-1-xiao.w.wang@intel.com> <3f10edab-be6d-9e48-d022-e569ae79adc7@intel.com> Openpgp: preference=signencrypt Message-ID: <556b4896-d311-a4ae-37e2-eacda2be5994@intel.com> Date: Tue, 2 Oct 2018 15:45:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3f10edab-be6d-9e48-d022-e569ae79adc7@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 14:46:04 -0000 On 9/21/2018 12:55 AM, Ferruh Yigit wrote: > On 9/10/2018 12:01 PM, Xiao Wang wrote: >> IFCVF can help to log dirty page in live migration stage, >> each queue's index can be read and configured to support >> VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE. >> >> Signed-off-by: Xiao Wang > > <...> > >> +static void >> +ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf) >> +{ >> + uint32_t i, size; >> + uint64_t pfn; >> + >> + pfn = hw->vring[queue].used / PAGE_SIZE; >> + size = hw->vring[queue].size * sizeof(struct vring_used_elem) + >> + sizeof(__virtio16) * 3; > > Getting a build error for PowerPC [1], can someone from PPC side confirm it please? > > [1] > .../drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_used_ring_log’: > .../drivers/net/ifc/ifcvf_vdpa.c:288:11: error: ‘__virtio16’ undeclared (first > use in this function) > sizeof(__virtio16) * 3; > ^~~~~~~~~~ Also "__virtio16" seems added into Linux kernel on v3.19. Systems with kernel version less than this causing build error. Can we replace "__virtio16" usage with basic types to prevent build error? If so can you please send this as a fix patch? Thanks, ferruh